Description
BasicTilemapTestSuite was never covered by the summer 2024 refactor campaign, but it is already close to the target format — 45 asserts across 24 tests, 1.9 per test, with most tests already one assert each.
Only three need attention:
| Test |
Kind |
Asserts |
Lines |
tilemap_get_frame |
async |
3 |
74 |
tile_set_get_empty |
fact |
3 |
44 |
draw_tilemap |
async |
0 direct |
70 |
tile_set_get_empty is a straightforward split. The two async draw tests should be reviewed rather than split reflexively — each drives multiple frames, and draw_tilemap performs its verification through the draw-comparison helpers rather than direct asserts, so it may need a different treatment entirely.
Separately, the suite's tests are not currently numbered; consider applying the <original_name> #N convention while in the file.
This is a small job and a good candidate for someone picking up the convention for the first time.
Script Name
BasicTilemapTestSuite
Steps To The Task
Description
BasicTilemapTestSuitewas never covered by the summer 2024 refactor campaign, but it is already close to the target format — 45 asserts across 24 tests, 1.9 per test, with most tests already one assert each.Only three need attention:
tilemap_get_frametile_set_get_emptydraw_tilemaptile_set_get_emptyis a straightforward split. The two async draw tests should be reviewed rather than split reflexively — each drives multiple frames, anddraw_tilemapperforms its verification through the draw-comparison helpers rather than direct asserts, so it may need a different treatment entirely.Separately, the suite's tests are not currently numbered; consider applying the
<original_name> #Nconvention while in the file.This is a small job and a good candidate for someone picking up the convention for the first time.
Script Name
BasicTilemapTestSuite
Steps To The Task
tile_set_get_emptyinto one fact per scenariotilemap_get_frameanddraw_tilemapand decide whether a split is worthwhile given they are multi-frame async tests, documenting the decision in the PR<original_name> #Nnaming convention to any fact that gains siblingstilemap_*vstile_*vs draw tests)