Skip to content

BasicNameofTestSuite: Split the multi-scenario facts #349

Description

@YYDan

Description

BasicNameofTestSuite was never covered by the summer 2024 refactor campaign. It is small — 9 asserts in 4 facts across 41 lines — but every fact bundles two or three independent checks:

Fact Asserts
nameof_macro_test 3 (real-valued macro, string-valued macro, tab-prefixed macro)
nameof_enum_test 2
nameof_global_test 2
nameof_localvar_test 2

Each assert is a fully independent check of nameof() against a different declaration kind, so this splits cleanly with no shared setup to duplicate.

Note the assert messages in nameof_localvar_test already carry #7 and #8 prefixes. Per convention these are preserved verbatim even though they will no longer match the new fact numbers.

Target: 9 facts.

Script Name

BasicNameofTestSuite

Steps To The Task

  • Split all four facts into one fact per assert, named <original_name> #N
  • Leave the existing macro, enum and global declarations at file scope where they are
  • Preserve the existing #7 / #8 assert message prefixes verbatim
  • Add section comment headers per declaration kind
  • Confirm the total assert count is unchanged (9) and that no fact name is duplicated
  • Run the suite on VM and YYC and confirm the same set of checks pass as before

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

refactorAn improvement to existing test/module code

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions