Skip to content

Add remote CI validation for pull requests #31

Description

@Yuto-24

Summary

Pull requests currently do not appear to have remote CI validation. During review of PR #30, the head commit had no associated workflow runs, so verification relied on local command output.

Add a minimal GitHub Actions workflow so PRs can be validated remotely before merge.

Motivation

For dependency/security remediation PRs, local validation alone is easy to miss in review. At minimum, PRs should show a remote check confirming that install and tests pass.

Initial scope

Add a GitHub Actions workflow that runs on pull requests targeting master.

Minimum commands:

npm ci
npm test

Suggested workflow file:

.github/workflows/ci.yml

Suggested job shape:

  • runner: ubuntu-latest

  • Node.js version: choose and pin one supported project version

  • steps:

    • checkout
    • setup-node with npm cache
    • npm ci
    • npm test

Out of scope for the first CI workflow

Do not require npm run build as a blocking check yet.

npm run build currently fails during the webpack step with a likely gas-webpack-plugin / webpack compatibility issue. That build failure is tracked separately and should be fixed before adding build as a required CI gate.

Acceptance criteria

  • A PR against master triggers a GitHub Actions workflow.
  • The workflow runs npm ci successfully.
  • The workflow runs npm test successfully.
  • PR checks show the CI result on GitHub.
  • npm run build is not required in this initial CI workflow.

Follow-up

After the webpack build issue is fixed, extend CI to include:

npm run build

At that point, build can be considered for a required status check.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions