From 169eaf7a3314b3ca6a3d10c04d289ccb9f51438c Mon Sep 17 00:00:00 2001 From: Daniel Meyer Date: Thu, 17 Sep 2026 15:01:38 -0700 Subject: [PATCH] fix(security): avoid GHA shell injection on acknowledge input --- .github/workflows/deploy-worker-pin-pr.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy-worker-pin-pr.yml b/.github/workflows/deploy-worker-pin-pr.yml index 9a0a853..47b2b0f 100644 --- a/.github/workflows/deploy-worker-pin-pr.yml +++ b/.github/workflows/deploy-worker-pin-pr.yml @@ -28,9 +28,11 @@ jobs: url: https://noema.guru steps: - name: Refuse missing production-deploy acknowledgement + env: + ACKNOWLEDGE: ${{ inputs.acknowledge }} run: | set -euo pipefail - if [ "${{ inputs.acknowledge }}" != "I_ACKNOWLEDGE_PRODUCTION_DEPLOY_AND_PIN" ]; then + if [ "$ACKNOWLEDGE" != "I_ACKNOWLEDGE_PRODUCTION_DEPLOY_AND_PIN" ]; then echo "::error::Set acknowledge=I_ACKNOWLEDGE_PRODUCTION_DEPLOY_AND_PIN. Merging this workflow does not deploy." exit 1 fi