refactor(code-index): centralize initialization error state

Author: WebMad

src/services/code-index/__tests__/manager.spec.ts

@@ -171,15 +171,15 @@ describe("CodeIndexManager - handleSettingsChange regression", () => {
 	})
 
 	describe("initialize", () => {
-		it("records initialization failures and rethrows the original error", async () => {
+		it("rethrows initialization failures without updating lifecycle state", async () => {
 			const error = new Error("configuration failed")
 			manager["_configManager"] = {
 				loadConfiguration: vi.fn().mockRejectedValue(error),
 			} as never
 
 			await expect(manager.initialize({} as never)).rejects.toBe(error)
 
-			expect(manager["_stateManager"].setSystemState).toHaveBeenCalledWith("Error", error.message)
+			expect(manager["_stateManager"].setSystemState).not.toHaveBeenCalled()
 		})
 	})
 

src/services/code-index/manager.ts

@@ -122,15 +122,6 @@ export class CodeIndexManager {
 	 * @returns Object indicating if a restart is needed
 	 */
 	public async initialize(contextProxy: ContextProxy): Promise<{ requiresRestart: boolean }> {
-		try {
-			return await this.initializeInternal(contextProxy)
-		} catch (error) {
-			this._stateManager.setSystemState("Error", error instanceof Error ? error.message : String(error))
-			throw error
-		}
-	}
-
-	private async initializeInternal(contextProxy: ContextProxy): Promise<{ requiresRestart: boolean }> {
 		// 1. ConfigManager Initialization and Configuration Loading
 		if (!this._configManager) {
 			this._configManager = new CodeIndexConfigManager(contextProxy)