"Override" followup No 2#109
Merged
Merged
Conversation
We should only use one term for this… From the LLM Chat: > Override = user/data that takes precedence over base behavior (e.g. "manual overrides"). Fits this feature: locally stored crossing segments that override/supplement the displayed/exported data. Common in config/settings. > > Overwrite = writing over and replacing existing content; can imply destructive replacement of source data. The feature is additive (added crossings), not replacing OSM.
Sorry I missed this; This is left over from an older iteration of the mode switcher.
dabreegster
approved these changes
Mar 15, 2026
| end: { lat: number; lng: number }; | ||
| }; | ||
|
|
||
| export type AddedCrossingSegment = SnappedSegment & { |
Collaborator
There was a problem hiding this comment.
I haven't used zod before, but a little surprised there's not a way to generate the TS type from it?
Contributor
Author
There was a problem hiding this comment.
There are and usually I do. But this case was so simple, that I thought to keep it written out…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback in #108
This does a bit of cleanup. And also improves the UI in some places.
I add https://zod.dev/packages/mini here which has a very small footprint.