Pass as numbers when using booleans

Author: aabajyan

internal/core/gen.go

@@ -96,6 +96,11 @@ func (v Params) Bindings() string {
 			continue
 		}
 
+		if f.Type.IsBoolean() {
+			out = append(out, fmt.Sprintf("($%s ? 1 : 0)", f.Name))
+			continue
+		}
+
 		out = append(out, fmt.Sprintf("$%s", f.Name))
 	}
 

internal/core/models.go

@@ -97,6 +97,10 @@ func (t phpType) String() string {
 	return v
 }
 
+func (t phpType) IsBoolean() bool {
+	return t.Name == "bool"
+}
+
 func (t phpType) IsDateTimeImmutable() bool {
 	return t.Name == "\\DateTimeImmutable"
 }

internal/tests/golden_test.go

@@ -73,3 +73,13 @@ func TestArgsWithDefaults(t *testing.T) {
 
 	runGoldenTest(t, testCase)
 }
+
+func TestBooleanBindings(t *testing.T) {
+	testCase := TestCase{
+		Name:    "boolean_bindings",
+		Engine:  "sqlite",
+		Package: "Test\\BooleanBindings",
+	}
+
+	runGoldenTest(t, testCase)
+}

internal/tests/testdata/boolean_bindings/expected/FeatureFlags.php

@@ -0,0 +1,19 @@
+<?php
+// @formatter:off
+// Code generated by sqlc. DO NOT EDIT.
+// versions:
+//   sqlc v1.30.0
+
+declare(strict_types=1);
+
+namespace Test\BooleanBindings;
+
+final readonly class FeatureFlags {
+    public function __construct(
+        public int $id,
+        public string $name,
+        public bool $enabled,
+    )
+    {}
+}
+

internal/tests/testdata/boolean_bindings/expected/Queries.php

@@ -0,0 +1,20 @@
+<?php
+// @formatter:off
+// Code generated by sqlc. DO NOT EDIT.
+// versions:
+//   sqlc v1.30.0
+
+declare(strict_types=1);
+
+namespace Test\BooleanBindings;
+
+interface Queries {
+  /**
+  *  @return FeatureFlags[]
+  */
+  public function listFlags(): array;
+  
+  public function setFlag(int $id, string $name, bool $enabled): void;
+  
+}
+

internal/tests/testdata/boolean_bindings/expected/QueriesImpl.php

@@ -0,0 +1,58 @@
+<?php
+// @formatter:off
+// Code generated by sqlc. DO NOT EDIT.
+// versions:
+//   sqlc v1.30.0
+
+declare(strict_types=1);
+
+namespace Test\BooleanBindings;
+
+const listFlags = "-- name: listFlags :many
+SELECT
+    id,
+    name,
+    enabled
+FROM
+    feature_flags
+ORDER BY
+    id
+";
+
+const setFlag = "-- name: setFlag :exec
+INSERT INTO
+    feature_flags (id, name, enabled)
+VALUES
+    (?, ?, ?)
+";
+
+final readonly class QueriesImpl implements Queries {
+    public function __construct(private \PDO $pdo) {}
+
+    /**
+     * @return FeatureFlags[]
+     * @throws \Exception
+     */
+    public function listFlags(): array
+    {
+        $stmt = $this->pdo->prepare(listFlags);
+        $stmt->execute();
+        $results = $stmt->fetchAll(\PDO::FETCH_NUM);
+        $ret = [];
+        foreach ($results as $row) {
+            $ret[] = new FeatureFlags($row[0], $row[1], $row[2]);
+        }
+        return $ret;
+    }
+
+    /**
+     * @throws \Exception
+     */
+    public function setFlag(int $id, string $name, bool $enabled): void
+    {
+        $stmt = $this->pdo->prepare(setFlag);
+        $stmt->execute([$id, $name, ($enabled ? 1 : 0)]);
+    }
+
+}
+

internal/tests/testdata/boolean_bindings/query.sql

@@ -0,0 +1,15 @@
+-- name: setFlag :exec
+INSERT INTO
+    feature_flags (id, name, enabled)
+VALUES
+    (?, ?, ?);
+
+-- name: listFlags :many
+SELECT
+    id,
+    name,
+    enabled
+FROM
+    feature_flags
+ORDER BY
+    id;

internal/tests/testdata/boolean_bindings/schema.sql

@@ -0,0 +1,5 @@
+CREATE TABLE feature_flags (
+    id INTEGER PRIMARY KEY,
+    name TEXT NOT NULL,
+    enabled BOOLEAN NOT NULL DEFAULT 0
+);