Skip to content

Severity vocabulary mismatch: REVIEW_SCHEMA.issues.severity vs code-reviewer persona wording #170

Description

@aaddrick

Problem

Deferred out of scope during PR #169 (issue #162, gate-hygiene). REVIEW_SCHEMA.issues.items.severity is ['critical', 'major', 'minor'], matching CHALLENGE_SCHEMA.findings. But .claude/agents/ticketmill-code-reviewer.md:31 instructs the reviewer to "report findings as a list with severity (blocking / major / minor)" — a different vocabulary (blocking vs critical).

.claude/agents/** is engine-owned and was correctly left untouched by PR #169, which only touched workflows/ticketmill.js and docs. This mismatch needs a dedicated pass over the agent persona file(s) to align the wording with the schema enum (or vice versa), and should account for lockstep sync with .claude/agents/** counterparts if any exist elsewhere.

Origin

Raised as a deferred, out-of-scope note across multiple code review iterations on PR #169 (issue #162), and left deferred through to merge.

Related PR: #169
Related issue: #162

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestgate-hygieneGate hygiene: findings, caps, and per-problem budgets (sequenced)

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions