fix: sync skill packs with configured branch#351
Open
kriptoburak wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Passes the configured branch from a stored SkillPack into _collect_pack_skills during sync so non-main packs (e.g. TweetClaw on master) clone the correct branch, matching the branch used elsewhere by discovery. Adds a regression test and documents TweetClaw as a concrete non-main smoke test.
Changes:
sync_skill_packnow forwardspack.branchto_collect_pack_skills.- New test verifies the configured branch is propagated and the resulting skill is stored.
- README and baseline-config docs describe TweetClaw as a non-
mainskill-pack example.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| backend/app/api/skills_marketplace.py | Pass pack.branch into _collect_pack_skills during sync. |
| backend/tests/test_skills_marketplace_api.py | Add regression test for branch propagation; update existing fake signature to keyword-only with branch. |
| docs/openclaw_baseline_config.md | Add TweetClaw smoke-test walkthrough with canonical links. |
| README.md | Mention TweetClaw skill pack and document the non-main branch smoke test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterbranch.mainskill-pack smoke test.Validation
cd backend && uv sync --extra dev && uv run pytest tests/test_skills_marketplace_api.py -qcd backend && uv run black --check app/api/skills_marketplace.py tests/test_skills_marketplace_api.py && uv run isort --check-only app/api/skills_marketplace.py tests/test_skills_marketplace_api.py && uv run flake8 app/api/skills_marketplace.py tests/test_skills_marketplace_api.pypython3 scripts/check_markdown_links.pygit diff --check@xquik/tweetclaw1.6.31 with npmSpec @xquik/tweetclaw@1.6.31 and defaultChoice npm; npm web page returned 403 bot protection to automated probeOutreach Checks
Risk
Low. The runtime change only passes an existing stored field into the existing collection helper, and the added docs describe a manual smoke test.