Skip to content

Commit b249196

Browse files
committed
fix: now first append return full message
see: https://ably.atlassian.net/wiki/x/QQDjIQE
1 parent 69a7527 commit b249196

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

test/ably/realtime/realtimechannelmutablemessages_test.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ async def test_append_message_with_string_data(self):
236236

237237
def on_message(message):
238238
messages_received.append(message)
239-
append_received.finish()
239+
if len(messages_received) == 2: append_received.finish()
240240

241241
await channel.subscribe(on_message)
242242

@@ -254,15 +254,21 @@ def on_message(message):
254254
channel, serial, MessageAction.MESSAGE_UPDATE
255255
)
256256

257+
second_append_result = await channel.append_message(append_message, append_operation)
258+
257259
await append_received.wait()
258260

259-
assert messages_received[0].data == ' appended data'
260-
assert messages_received[0].action == MessageAction.MESSAGE_APPEND
261+
assert messages_received[0].data == 'Initial data appended data'
262+
assert messages_received[0].action == MessageAction.MESSAGE_UPDATE
261263
assert appended_message.data == 'Initial data appended data'
262264
assert appended_message.version.serial == append_result.version_serial
263265
assert appended_message.version.description == 'Appended to message'
264266
assert appended_message.serial == serial
265267

268+
assert messages_received[1].data == ' appended data'
269+
assert messages_received[1].action == MessageAction.MESSAGE_APPEND
270+
assert messages_received[1].version.serial == second_append_result.version_serial
271+
266272
async def wait_until_message_with_action_appears(self, channel, serial, action):
267273
message: Message | None = None
268274
async def check_message_action():

0 commit comments

Comments
 (0)