diff --git a/src/modules/admin/admin.controllers.ts b/src/modules/admin/admin.controllers.ts index 6f16f3b..9d66c6b 100644 --- a/src/modules/admin/admin.controllers.ts +++ b/src/modules/admin/admin.controllers.ts @@ -2,7 +2,7 @@ import { AsyncController } from '../../types/auth.types'; import { sendSuccess, sendValidationError, - sendNotFound, + sendCreatorParamNotFound, sendForbidden, } from '../../utils/api-response.utils'; import { prisma } from '../../utils/prisma.utils'; @@ -61,7 +61,7 @@ export const httpUpdateCreatorMetadata: AsyncController = async ( }); if (!creator) { - return sendNotFound(res, 'Creator'); + return sendCreatorParamNotFound(res); } const previousValues = { diff --git a/src/utils/api-response.utils.ts b/src/utils/api-response.utils.ts index 767afb3..a420aee 100644 --- a/src/utils/api-response.utils.ts +++ b/src/utils/api-response.utils.ts @@ -187,6 +187,10 @@ export function sendNotFound(res: Response, resource: string): void { sendError(res, 404, ErrorCode.NOT_FOUND, `${resource} not found`); } +export function sendCreatorParamNotFound(res: Response): void { + sendNotFound(res, 'Creator'); +} + export function sendUnauthorized( res: Response, message = 'Unauthorized access', diff --git a/src/utils/test/api-response.utils.test.ts b/src/utils/test/api-response.utils.test.ts index 5f4db55..27b6405 100644 --- a/src/utils/test/api-response.utils.test.ts +++ b/src/utils/test/api-response.utils.test.ts @@ -2,6 +2,7 @@ import { Response } from 'express'; import { sendForbidden, sendUnauthorized, + sendCreatorParamNotFound, buildErrorResponse, zodIssuesToDetails, ErrorCode, @@ -17,6 +18,7 @@ describe('api-response.utils', () => { jsonMock = jest.fn(); statusMock = jest.fn().mockReturnValue({ json: jsonMock }); mockResponse = { + setHeader: jest.fn(), status: statusMock, }; }); @@ -65,6 +67,21 @@ describe('api-response.utils', () => { }); }); }); + + describe('sendCreatorParamNotFound', () => { + it('should send the shared creator parameter not-found response', () => { + sendCreatorParamNotFound(mockResponse as Response); + + expect(statusMock).toHaveBeenCalledWith(404); + expect(jsonMock).toHaveBeenCalledWith({ + success: false, + error: { + code: ErrorCode.NOT_FOUND, + message: 'Creator not found', + }, + }); + }); + }); }); describe('buildErrorResponse', () => {