Skip to content

malformed external_dependencies (edge-case) #80

Description

@2bndy5

I have a CirPy lib that uses spidev on Linux (yields much better performance than pureio). I have listed spidev in the lib's requirements.txt like so

adafruit-circuitpython-busdevice
spidev; sys_platform == 'linux'

The ; sys_platform == 'linux' is advice taken from pip's docs, but this makes the bundle's JSON external_dependencies look like so:

        "external_dependencies": [
            "adafruit-circuitpython-busdevice",
            "spidev; sys_platform "
        ]

I'm mandating the spidev module on Linux only because linting the lib when developing requires that the development changes be installed (spidev can't be installed on Windows). Granted, I still have to ignore warnings about import spidev in my lib's examples, but that's what hardware testing is for.

Feel free to close this issue if there are no foreseen consequences with circuitpython.org.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions