Panic in func WebsocketClient.disconnectAndRetry

[canselcik]

The library seems to panic on occasion in:

func (w *WebsocketClient) disconnectAndRetry() {
	w.log.Warn("disconnected")
	w.heartbeat.Stop()
	w.conMutex.Lock()
	w.connected = false
	w.conMutex.Unlock()
	w.log.Info("retrying websocket connection in 30s")
	time.Sleep(30 * time.Second)
	w.Restart()
}

at the line w.heartbeat.Stop(). Seems like w.heartbeat can be nil at times.

Patching so that it reads:

if w.heartbeat != nil {
  w.heartbeat.Stop()
}

fixes the panic however w.heartbeat being nil at that time likely points to some other race condition.

[adampointer]

Hmm yes I will run the race detector on this.

[0cv]

Not sure it's related but when simulating a disconnection (as simple as by turning off the wifi), I'm getting a panic when I turn back on the wifi:

Edit: the patch above doesn't help

Edit2: socket.Conn is nil, then the seg fault happens. Adding this is enough: