Warning + Cognitive Complexity

[adeutscher]

Address warnings during build process and deal with the manageable cases of Sonar warning about cognitive complexity

[adeutscher]

• Hit test/ with a Cursor-shaped hammer
• Manually fixed src/ warnings

[adeutscher]

Asked Cursor report on outstanding cases of S3776 (wherein Cognitive Complexity is greater than 15). Will tackle the output of that command next session.

From Sonar rule S3776 (Cognitive Complexity > 15), run locally with SonarAnalyzer.CSharp against src (no Sonar report was in the repo):

Complexity	Method	Location
21	ConfigureWorker	src/RedShirt.Example.JobWorker/Extensions/ServiceCollectionExtensions.cs:26
19	RunAsync	src/RedShirt.Example.JobWorker.Core/Services/MessagePolling/LoaderModeJobLoader.cs:27
19	SetResultInCacheAsync	src/RedShirt.Example.JobWorker.Core/Services/Idempotency/IdempotencyExecutionService.cs:211
16	GetNextJobAsync	src/RedShirt.Example.JobWorker.Core/Services/Jobs/JobRepository.cs:140

Those four are the only src methods Sonar flagged above the default limit of 15.

Off-the-cuff comments:

• I'm glad that all of these are Core or Host/Root problems.
• That said, the manual src/ fixes did involve content in Common projects, so that does block my API sync-up ToDo item of Updated standards based on JobWorker template (2026-08) RedShirt.Example.Api#1 until this issue is done
• I'm not 100% sure what I'll be able to do about ConfigureWorker while also keeping things the template nice and convenient to prune, but we'll see. It may just be a case that I let slide because it's a general template.

[adeutscher]

Labelled this as a bug, but admittedly the performance of the actual program isn't impacted at all.

[adeutscher]

ConfigureWorker ended up being resolvable by moving towards a switch statement and determining toggled job sources in a loop.

[adeutscher]

Everything immediate is resolved. Doing one final sweep for methods in the Cognitive Complexity danger zone of 14 or 15.

Result:

No methods at cognitive complexity 14 or 15 under Sonar’s CSharpCognitiveComplexityMetric (S3776 threshold is 15; failure is >15).

Scored all methods under src/ with SonarAnalyzer.CSharp 10.15.0.120848.

Complexity	Method	Location
—	(none)	—

Highest in the tree is 12 (IdempotencyMonitor.CheckBlockedJobsAsync). Nothing is currently within one point of the S3776 limit.

IdempotencyExecutionService (for context) (this is just the file that I happened to have open when I ran this prompt)

Complexity	Method
9	GetLockAsync
9	GetCachedResultAsync
5	SetResultInCacheAsync
5	SetResultInCacheInnerAsync
5	ClearCacheResultAsync

So that's good, apparently nothing else is in the danger zone.