Skip to content

[bug] removeDefaultStyles does not remove default styles on ResponsiveGrid #292

Description

@cjwiseman11

Describe the bug
Adding removeDefaultStyles to ResponsiveGrid does not remove styles.

Ref: https://github.com/adobe/aem-react-editable-components/blob/master/src/components/ResponsiveGrid.tsx#L45

  if (isInEditor || !props.removeDefaultStyles) {
    className = `${className} ${props.gridClassNames || ''} ${ClassNames.CONTAINER}`;
  }

The code here shows that isInEditor will always return true and it seems impossible to override gridClassNames prop.

We want to use a custom grid but this is forcing our hand.

Package version
2.1.1

To Reproduce

  1. Add removeDefaultStyles to ResponsiveGrid

Expected behavior
Grid styles removed in AEM

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions