JSON API update -RPC Protocol Broken#3
Open
dylanPowers wants to merge 104 commits into
Open
Conversation
added 14 commits
May 13, 2012 01:52
Author
|
Btw, I just noticed some previous pull requests that were made to this repo 7 months ago, but why weren't they merged? Think you could spend some time organizing everything that's been done so far? I'd definitely be interested in using github as our primary repo rather than google code or where ever else you have code hanging around. |
Move away from hard-coded strings, and clean up the layouts
Using images from a themed Pandora app now, will change later.
Added ActionBar to everything, and a landscape layout. Changed notification icon to be more 2.3+ish. Still need new control button icons
…Pandora One accounts will be unable to connect!
Removed all warnings, unused imports, and better exception logging.
Closes github issue #12
This completes the dynamic downloading feature for github issue #4.
It's better to fix the awkwardly unnecessary ".andoroid" suffix now rather than later.
1.0.0-Pre-5 version bump
Fixes github issue #14
(Stupid f***ing shitacular Java that can't understand null is equivalent to false)
Fixes github issue #17
Tweaks to the playback controller. Version bump to 1.0.0-Pre-7 Completes github issue #11
Fixes github issue #13
Miscellaneous bug fixes from the last commit.
This is a CM10 specific issue where the OS only sends out 100% buffering updates through the MediaPlayer API when playing AAC audio. The cached player will now start buffering automatically after 30 seconds if only 100% buffering updates are sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app needed an update to Pandora's JSON API as is used by their native Android app, so here you go! It's all mostly fixed up. I haven't totally implemented 100% of the previous functionality yet, but it plays music! Yay!!!!! I'm not too sure about the functionality for non-PandoraOne users (as I am a paying PandoraOne user), but I currently have the audio quality pegged at 192 kbps MP3. It rocks! Now my ears don't have to bleed when listening on my phone =P