From ef443eb0e73e909c212ecf21341402275483aa71 Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Mon, 7 Apr 2025 12:29:42 +0200 Subject: [PATCH 1/4] Include all relevant modules to publish profile Not sure what the idea was behind not publishing the service and its dependencies, but it's causing the code not to be compiled/tested when building the PR. And these should be published to nexus anyway I think? --- pom.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pom.xml b/pom.xml index 455cf88..ef9481f 100644 --- a/pom.xml +++ b/pom.xml @@ -194,6 +194,12 @@ publish + search-service + search-service-extension + search-service-geo + search-service-pdok-locatieservice + search-service-bing-geocoder + search-service-n2000-assessment-areas-nl search-shared search-client From 87c51a1c17cbe3f8cd91c0c3431fc17cd3890a67 Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Fri, 13 Mar 2026 14:29:15 +0100 Subject: [PATCH 2/4] re-introduce the PR action it was removed with f17cdc8d3041797ed050e3856ca9e17ca38c66ef, which seemed a bit weird? Assume it was just supposed to remove just the docker build part. --- ...ll_request-opened-synchronize-reopened.yml | 22 +++++++++++++++++++ pom.xml | 6 ----- 2 files changed, 22 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/on-pull_request-opened-synchronize-reopened.yml diff --git a/.github/workflows/on-pull_request-opened-synchronize-reopened.yml b/.github/workflows/on-pull_request-opened-synchronize-reopened.yml new file mode 100644 index 0000000..a128f4d --- /dev/null +++ b/.github/workflows/on-pull_request-opened-synchronize-reopened.yml @@ -0,0 +1,22 @@ +name: pull_request-opened-synchronize-reopened-event + +on: + pull_request: + types: [opened, synchronize, reopened] + +jobs: + job: + runs-on: ubuntu-latest + + steps: + - name: Check out github-actions repo + uses: actions/checkout@v4 + with: + repository: aerius/github-actions + path: aerius-github-actions + ref: v1.1 + + - uses: aerius/github-actions/events/pull_request-event-action@v1.1 + with: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + IGNORE_TEST_FAILURES: false diff --git a/pom.xml b/pom.xml index ef9481f..455cf88 100644 --- a/pom.xml +++ b/pom.xml @@ -194,12 +194,6 @@ publish - search-service - search-service-extension - search-service-geo - search-service-pdok-locatieservice - search-service-bing-geocoder - search-service-n2000-assessment-areas-nl search-shared search-client From 50902d059e4e708411da03bfb28fd1a243c7f2f1 Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Fri, 13 Mar 2026 17:04:06 +0100 Subject: [PATCH 3/4] Adjust jenkinsfile for PRs to not skip tests Also not specifying a profile, as search does not have a 'deploy' profile anyway. --- Jenkinsfile-PullRequestChecker | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Jenkinsfile-PullRequestChecker b/Jenkinsfile-PullRequestChecker index ccb0eea..6622876 100644 --- a/Jenkinsfile-PullRequestChecker +++ b/Jenkinsfile-PullRequestChecker @@ -9,7 +9,7 @@ cicdPipeline(agentLabel: PIPELINE_AGENT_LABEL) { docker.image(DOCKER_MAVEN_IMAGE).inside { sh ''' - mvn clean verify -Pdeploy -DskipTests --no-transfer-progress + mvn clean verify --no-transfer-progress ''' } From 1cd4190add3f8b909486ca8aa0ad971bb11aa463 Mon Sep 17 00:00:00 2001 From: Bert Scholten Date: Tue, 24 Mar 2026 09:27:50 +0100 Subject: [PATCH 4/4] Remove PR action again Jenkins already builds on PR, no real need to do it twice. Though jenkins isn't publicly reachable, so not as transparent for people outside AERIUS, it's also not like we had people outside contributing. --- ...ll_request-opened-synchronize-reopened.yml | 22 ------------------- 1 file changed, 22 deletions(-) delete mode 100644 .github/workflows/on-pull_request-opened-synchronize-reopened.yml diff --git a/.github/workflows/on-pull_request-opened-synchronize-reopened.yml b/.github/workflows/on-pull_request-opened-synchronize-reopened.yml deleted file mode 100644 index a128f4d..0000000 --- a/.github/workflows/on-pull_request-opened-synchronize-reopened.yml +++ /dev/null @@ -1,22 +0,0 @@ -name: pull_request-opened-synchronize-reopened-event - -on: - pull_request: - types: [opened, synchronize, reopened] - -jobs: - job: - runs-on: ubuntu-latest - - steps: - - name: Check out github-actions repo - uses: actions/checkout@v4 - with: - repository: aerius/github-actions - path: aerius-github-actions - ref: v1.1 - - - uses: aerius/github-actions/events/pull_request-event-action@v1.1 - with: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - IGNORE_TEST_FAILURES: false