Skip to content

follow-up: harden welcome eval relevance and live-signal stability #2180

Description

@Gandy2025

Context

PR #2170 merged the first onboarding chat into a bounded, value-first in-chat work loop. Its release scope included the reproduced core-contract fixes: premature PR/MR menus, broad post-result scans, and a bridge that must be directly related to the completed result.

This issue tracks post-merge eval hardening. It must not be used to defer a reproduced user-visible safety or core-flow defect from a source fix.

Follow-up scope

  • Make broad repository-scan detection aware of tool working directories and shell cd state. Equivalent repo-relative recursive scans such as cd source-repo && rg --files, (cd source-repo; find . -type f), and recursive commands executed with the tool workdir set to source-repo must be classified the same as explicit find source-repo ... commands.
  • Generalize post-result bridge relevance coverage beyond checkout/payment fixture wording so generic verbs such as verify cannot satisfy relevance by themselves.
  • Stabilize the tree-kickoff live-gate signal that produced one semantically compliant literal-signal false negative.
  • Reduce periodic oracle false-positive/false-negative noise while preserving hard failures for broad scans, unauthorized writes, premature PR/setup, role leaks, and first-task fan-out.
  • Promote reusable findings to the appropriate committed skill-eval or QA case disposition.

Acceptance

  • Add red-to-green controls for explicit-path, shell-cd, subshell-cd, and tool-workdir repo-relative recursive scans; retain passing controls for bounded direct-reference reads.
  • Add good, bad, and borderline bridge-relevance controls across at least three distinct repository domains.
  • Demonstrate that a directly related next step passes while unrelated or invented adjacent paths fail, without fixture-brand coupling.
  • Demonstrate stable tree-kickoff classification for semantically compliant outputs.
  • Keep every existing safety and role/setup regression green.
  • Document whether each resulting case belongs in deterministic skill eval, live periodic QA, or both.

Related: #2170

Review finding: #2170 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions