fix(ci): satisfy strict clippy checks and guardrails

Author: omoshola-o

benches/mcp_bench.rs

@@ -12,7 +12,7 @@ fn mcp_json_parse(c: &mut Criterion) {
 fn mcp_tool_dispatch(c: &mut Criterion) {
     c.bench_function("mcp_tool_dispatch", |b| {
         b.iter(|| {
-            let tools = vec!["tool1", "tool2", "tool3", "tool4", "tool5"];
+            let tools = ["tool1", "tool2", "tool3", "tool4", "tool5"];
             let target = "tool3";
             black_box(tools.iter().find(|&&t| t == target));
         })

src/bridges/traits.rs

@@ -1,6 +1,5 @@
 /// Bridge traits for inter-sister communication.
 /// All methods have NoOp defaults for standalone operation.
-
 pub trait MemoryBridge {
     fn store_context(&self, _key: &str, _value: &str) -> Result<(), String> {
         Ok(())

src/cache/lru.rs

@@ -75,9 +75,9 @@ impl<K: Eq + Hash + Clone, V: Clone> LruCache<K, V> {
     }
 
     pub fn contains(&self, key: &K) -> bool {
-        self.store.get(key).map_or(false, |e| {
-            Instant::now().duration_since(e.inserted_at) <= self.ttl
-        })
+        self.store
+            .get(key)
+            .is_some_and(|e| Instant::now().duration_since(e.inserted_at) <= self.ttl)
     }
 
     pub fn len(&self) -> usize {

src/mcp/server.rs

@@ -20,7 +20,7 @@ use crate::workspace::{ContextRole, TranslationMap, TranslationStatus, Workspace
 use super::protocol::{JsonRpcError, JsonRpcRequest, JsonRpcResponse};
 
 /// Inject token conservation parameters into every tool's inputSchema.
-fn inject_token_conservation_params(tools: &mut Vec<Value>) {
+fn inject_token_conservation_params(tools: &mut [Value]) {
     let conservation_props = json!({
         "include_content": { "type": "boolean", "default": false, "description": "Return full content (default: IDs only)" },
         "intent": { "type": "string", "enum": ["exists", "ids", "summary", "fields", "full"], "description": "Extraction intent level" },

src/metrics/audit.rs

@@ -31,6 +31,7 @@ pub struct AuditEntry {
 
 impl AuditEntry {
     /// Create a new audit entry with the current timestamp.
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         tool: impl Into<String>,
         layer: Layer,

src/query/intent.rs

@@ -4,11 +4,12 @@ use serde::{Deserialize, Serialize};
 ///
 /// Ordered from cheapest (fewest tokens) to most expensive.
 /// Default is `IdsOnly` to be maximally token-conservative.
-#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Default, Serialize, Deserialize)]
 pub enum ExtractionIntent {
     /// Only check if the item exists. Cheapest possible query.
     Exists,
     /// Return only identifiers. Default and very cheap.
+    #[default]
     IdsOnly,
     /// Return a compact summary (key fields only).
     Summary,
@@ -42,12 +43,6 @@ impl ExtractionIntent {
     }
 }
 
-impl Default for ExtractionIntent {
-    fn default() -> Self {
-        ExtractionIntent::IdsOnly
-    }
-}
-
 /// Trait for types that can have an extraction intent applied to scope their output.
 pub trait Scopeable {
     /// The scoped output type.