feat: migrate install-mcp-servers.sh to read from sister registry

Replace all hardcoded sister arrays and the manual JSON block with
jq-driven reads from docs/sisters-registry.json. The MCP config
(~/.claude/mcp.json) is now generated dynamically from the registry.

Author: omoshola-o

scripts/check-canonical-consistency.sh

@@ -1268,17 +1268,18 @@ else
   done
   pass "All registry sisters have required fields"
 
-  # Verify key scripts source from registry (not hardcoded)
+  # Verify key scripts reference the registry (not hardcoded)
   REGISTRY_CONSUMERS=(
     "scripts/check-canonical-consistency.sh"
     "scripts/check-command-surface.sh"
+    "scripts/install-mcp-servers.sh"
   )
   for script in "${REGISTRY_CONSUMERS[@]}"; do
     if [ -f "${WORKSPACE}/${script}" ]; then
-      if grep -qF "load-sisters.sh" "${WORKSPACE}/${script}"; then
-        pass "${script} sources from registry via load-sisters.sh"
+      if grep -qF "load-sisters.sh" "${WORKSPACE}/${script}" || grep -qF "sisters-registry.json" "${WORKSPACE}/${script}"; then
+        pass "${script} reads from registry"
       else
-        fail "${script} does not source load-sisters.sh (may have hardcoded sister list)"
+        fail "${script} does not reference registry (may have hardcoded sister list)"
       fi
     fi
   done

scripts/install-mcp-servers.sh

@@ -1,16 +1,20 @@
 #!/usr/bin/env bash
-# install-mcp-servers.sh — Build and install all 5 agentic sister MCP servers
+# install-mcp-servers.sh — Build and install all agentic sister MCP servers
 # and configure ~/.claude/mcp.json to use the stable cargo-installed paths.
 #
 # Usage: bash scripts/install-mcp-servers.sh
 #
+# Sister definitions are read from docs/sisters-registry.json (single source
+# of truth). To add a new sister, edit the registry — not this file.
+#
 # This script is idempotent — safe to re-run after code changes.
 
 set -euo pipefail
 
 WORKSPACE_ROOT="$(cd "$(dirname "$0")/.." && pwd)"
 CARGO_BIN="${CARGO_HOME:-$HOME/.cargo}/bin"
 CLAUDE_MCP_CONFIG="$HOME/.claude/mcp.json"
+REGISTRY="${WORKSPACE_ROOT}/docs/sisters-registry.json"
 
 # Colors
 RED='\033[0;31m'
@@ -24,46 +28,25 @@ ok()    { echo -e "${GREEN}[ok]${NC}    $*"; }
 warn()  { echo -e "${YELLOW}[warn]${NC}  $*"; }
 fail()  { echo -e "${RED}[fail]${NC}  $*"; exit 1; }
 
-# ── Sister definitions ─────────────────────────────────────────────
-declare -a SISTERS=(
-  "agentic-memory"
-  "agentic-vision"
-  "agentic-codebase"
-  "agentic-identity"
-  "agentic-time"
-)
-
-declare -A MCP_CRATE_PATH=(
-  [agentic-memory]="agentic-memory/crates/agentic-memory-mcp"
-  [agentic-vision]="agentic-vision/crates/agentic-vision-mcp"
-  [agentic-codebase]="agentic-codebase/crates/agentic-codebase-mcp"
-  [agentic-identity]="agentic-identity/crates/agentic-identity-mcp"
-  [agentic-time]="agentic-time/crates/agentic-time-mcp"
-)
-
-declare -A MCP_BIN_NAME=(
-  [agentic-memory]="agentic-memory-mcp"
-  [agentic-vision]="agentic-vision-mcp"
-  [agentic-codebase]="agentic-codebase-mcp"
-  [agentic-identity]="agentic-identity-mcp"
-  [agentic-time]="agentic-time-mcp"
-)
-
-declare -A MCP_ARGS=(
-  [agentic-memory]='["serve"]'
-  [agentic-vision]='["--log-level", "error", "serve"]'
-  [agentic-codebase]='[]'
-  [agentic-identity]='[]'
-  [agentic-time]='[]'
-)
+if [ ! -f "$REGISTRY" ]; then
+  fail "sisters-registry.json not found at $REGISTRY"
+fi
+
+if ! command -v jq >/dev/null 2>&1; then
+  fail "jq is required but not installed"
+fi
+
+SISTER_COUNT=$(jq '.sisters | length' "$REGISTRY")
 
 # ── Step 1: Build and install all MCP binaries ─────────────────────
 info "Building and installing MCP server binaries..."
 FAILED=0
 
-for sister in "${SISTERS[@]}"; do
-  crate_path="${WORKSPACE_ROOT}/${MCP_CRATE_PATH[$sister]}"
-  bin_name="${MCP_BIN_NAME[$sister]}"
+for i in $(seq 0 $((SISTER_COUNT - 1))); do
+  sister=$(jq -r ".sisters[$i].repo" "$REGISTRY")
+  bin_name=$(jq -r ".sisters[$i].mcp.binary" "$REGISTRY")
+  crate_rel=$(jq -r ".sisters[$i].mcp.cratePath" "$REGISTRY")
+  crate_path="${WORKSPACE_ROOT}/${sister}/${crate_rel}"
 
   if [ ! -d "$crate_path" ]; then
     warn "Skipping $sister — crate path not found: $crate_path"
@@ -96,43 +79,29 @@ info "Updating $CLAUDE_MCP_CONFIG ..."
 
 mkdir -p "$(dirname "$CLAUDE_MCP_CONFIG")"
 
-# Build JSON manually to avoid jq dependency
-cat > "$CLAUDE_MCP_CONFIG" << MCPJSON
-{
-  "mcpServers": {
-    "agentic-memory": {
-      "command": "$CARGO_BIN/agentic-memory-mcp",
-      "args": ["serve"]
-    },
-    "agentic-vision": {
-      "command": "$CARGO_BIN/agentic-vision-mcp",
-      "args": ["--log-level", "error", "serve"]
-    },
-    "agentic-codebase": {
-      "command": "$CARGO_BIN/agentic-codebase-mcp",
-      "args": []
-    },
-    "agentic-identity": {
-      "command": "$CARGO_BIN/agentic-identity-mcp",
-      "args": [],
-      "env": {}
-    },
-    "agentic-time": {
-      "command": "$CARGO_BIN/agentic-time-mcp",
-      "args": []
-    }
+# Build MCP config dynamically from registry
+jq -n --arg cargo_bin "$CARGO_BIN" --slurpfile reg "$REGISTRY" '
+  {
+    mcpServers: (
+      $reg[0].sisters | map({
+        key: .repo,
+        value: {
+          command: ($cargo_bin + "/" + .mcp.binary),
+          args: .mcp.args
+        }
+      }) | from_entries
+    )
   }
-}
-MCPJSON
+' > "$CLAUDE_MCP_CONFIG"
 
 ok "MCP config written to $CLAUDE_MCP_CONFIG"
 
 # ── Step 3: Verify all binaries are reachable ──────────────────────
 info "Verifying installed binaries..."
 ALL_OK=true
 
-for sister in "${SISTERS[@]}"; do
-  bin_name="${MCP_BIN_NAME[$sister]}"
+for i in $(seq 0 $((SISTER_COUNT - 1))); do
+  bin_name=$(jq -r ".sisters[$i].mcp.binary" "$REGISTRY")
   bin_path="$CARGO_BIN/$bin_name"
   if [ -x "$bin_path" ]; then
     ok "$bin_name ✓"
@@ -144,7 +113,7 @@ done
 
 if $ALL_OK; then
   echo ""
-  ok "All 5 sister MCP servers installed and configured."
+  ok "All $SISTER_COUNT sister MCP servers installed and configured."
   info "Restart Claude Code to pick up the new binaries."
 else
   echo ""