refactor(core): remove redundant hasPendingToolUse check in doCall

xichaodong · xichaodong · commit 99dfdb68829d · 2026-04-08T20:05:38.000+08:00
The check at line 275 is always true because the early return at
line 268 already guarantees pendingIds is non-empty at that point.
Simplify to call acting(0) directly.
diff --git a/agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java b/agentscope-core/src/main/java/io/agentscope/core/ReActAgent.java
@@ -272,7 +272,7 @@ protected Mono<Msg> doCall(List<Msg> msgs) {
 
         // Has pending tools but no input -> resume (execute pending tools directly)
         if (msgs == null || msgs.isEmpty()) {
-            return hasPendingToolUse() ? acting(0) : executeIteration(0);
+            return acting(0);
         }
 
         // Has pending tools + input -> check if user provided tool results

Original file line number	Diff line number	Diff line change
`@@ -272,7 +272,7 @@ protected Mono<Msg> doCall(List<Msg> msgs) {`
`272`	`272`
`273`	`273`	`// Has pending tools but no input -> resume (execute pending tools directly)`
`274`	`274`	`if (msgs == null \|\| msgs.isEmpty()) {`
`275`		`- return hasPendingToolUse() ? acting(0) : executeIteration(0);`
	`275`	`+ return acting(0);`
`276`	`276`	`}`
`277`	`277`
`278`	`278`	`// Has pending tools + input -> check if user provided tool results`