From 0de8a7337dd77a41a35614ec1f27021c8921b3db Mon Sep 17 00:00:00 2001 From: Viren Baraiya Date: Sat, 16 May 2026 09:10:57 -0700 Subject: [PATCH] fix(ci): java-e2e ``needs: [..., test]`` references a non-existent job PR #239 added a ``java-e2e`` job to ``ci.yml`` with ``needs: [build-server, test]``. ``test`` is the job name inside the separate ``ci-java-sdk.yml`` workflow, but ``needs:`` in GitHub Actions only resolves jobs in the *same* workflow file. The dangling reference invalidated ``ci.yml`` as a whole: every push to main produced a 0-job failure run with the workflow name displayed as ``.github/workflows/ci.yml`` (the file path) instead of ``CI``, and the push-event runs at https://github.com/agentspan-ai/agentspan/actions/runs/25955164702 (and many others since 3f748c59) failed instantly. The two workflows already run in parallel by virtue of being separate workflow files. Drop the dangling ``test`` dep; ``build-server`` (the actual server-jar producer that java-e2e consumes) is the only real prerequisite from inside ``ci.yml``. This is the same fix that's already on PR #238 (feat/pac-pae, commit bf362224); landing it on main unblocks every other open PR's CI run immediately rather than waiting for the larger PAC/PAE branch to land. --- .github/workflows/ci.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c532a50c0..ca4fad751 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -274,7 +274,14 @@ jobs: # ── Java E2E Tests ───────────────────────────────────────────────── java-e2e: runs-on: ubuntu-latest - needs: [build-server, test] + # ``test`` was the job name in the separate ci-java-sdk.yml workflow. + # GitHub Actions ``needs:`` only resolves jobs in the same workflow, so + # listing it here was a dangling reference that invalidated ci.yml as a + # whole — every push to main produced a 0-job failure run with the + # workflow name displayed as ``.github/workflows/ci.yml`` instead of + # ``CI``. Depend only on ``build-server`` (the actual server-jar + # producer); the separate java-sdk workflow runs in parallel. + needs: [build-server] timeout-minutes: 45 env: OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}