Correct injected-floor test explanation
Context
an_injected_floor_inside_the_implemented_range_refuses_only_below_itself correctly proves that an injected manifest-format floor can reject a package at the build floor while accepting the producer version. Its explanatory comment says this became reachable only with the limit_nofile bump because the earlier accepted range was a point. That statement contradicts check_format_version's documentation, which states that values inside the implemented range have existed since manifest format version 4. The range was already 3..=4 before the descriptor-limit bump, so the comment is misleading even though the test behavior is correct.
Scope
Correct the historical explanation on the injected-floor test so it accurately describes the pre-existing multi-version accepted range and the behavior the test exercises. Keep the test's actual package construction, injected floor, and acceptance/refusal assertions unchanged unless a correction to their accompanying explanation requires a matching name or prose adjustment.
Acceptance criteria
Constraints
Do not change manifest-format constants, parser behavior, verifier behavior, or the descriptor-limit feature. This is a correction of misleading test documentation, not a redesign of injected-floor semantics.
Out of scope
Adding a separate test with a strictly interior floor, changing the accepted format-version window, or altering the trust-set schema is out of scope.
Test plan
Dependencies
Part of #78.
Pointers
src/verify.rs:992 — the corrected check_format_version rustdoc describing when an injected floor is observable inside the implemented range.src/verify.rs:2334 — the injected-floor test whose explanatory comment needs correction.src/verify.rs:2360 — the test's producer-version injected floor and behavior to preserve.
Correct injected-floor test explanation
Context
an_injected_floor_inside_the_implemented_range_refuses_only_below_itselfcorrectly proves that an injected manifest-format floor can reject a package at the build floor while accepting the producer version. Its explanatory comment says this became reachable only with thelimit_nofilebump because the earlier accepted range was a point. That statement contradictscheck_format_version's documentation, which states that values inside the implemented range have existed since manifest format version 4. The range was already3..=4before the descriptor-limit bump, so the comment is misleading even though the test behavior is correct.Scope
Correct the historical explanation on the injected-floor test so it accurately describes the pre-existing multi-version accepted range and the behavior the test exercises. Keep the test's actual package construction, injected floor, and acceptance/refusal assertions unchanged unless a correction to their accompanying explanation requires a matching name or prose adjustment.
Acceptance criteria
check_format_version's statement that an injected floor can sit inside the implemented range since manifest format version 4.Constraints
Do not change manifest-format constants, parser behavior, verifier behavior, or the descriptor-limit feature. This is a correction of misleading test documentation, not a redesign of injected-floor semantics.
Out of scope
Adding a separate test with a strictly interior floor, changing the accepted format-version window, or altering the trust-set schema is out of scope.
Test plan
an_injected_floor_inside_the_implemented_range_refuses_only_below_itselftest and the repository's required test suite.check_format_versionrustdoc together to confirm their historical statements agree.Dependencies
Part of #78.
Pointers
src/verify.rs:992— the correctedcheck_format_versionrustdoc describing when an injected floor is observable inside the implemented range.src/verify.rs:2334— the injected-floor test whose explanatory comment needs correction.src/verify.rs:2360— the test's producer-version injected floor and behavior to preserve.