About ip2location

[sehkone]

@msk

I see that you specified version 0.5.4 of ip2location while changing Arc<Mutex<ip2location::DB>> to just ip2location::DB. I'm curious where you found this change in ip2location and why you pinpointed version 0.5.4 specifically. Could you let me know about it?

[msk]

The change was prompted by updates to the ip2location crate. In earlier versions, the lookup API required a mutable reference, which necessitated the use of Arc<Mutex<ip2location::DB>>. However, after updating the ip2location version for review-database, the compiler indicated that a mutable reference was no longer needed.

To confirm this, I checked the relevant code in the ip2location repository and found that the lookup API now takes a shared reference (&self) instead of a mutable one (&mut self). This change eliminated the need for a Mutex.

I chose version 0.5.4 in Cargo.toml because of this issue, which suggested improvements in the library's API. While the actual change to the reference type might have occurred in an earlier version, I didn’t dig further into the git history since 0.5.4 addressed the immediate requirement.

[sehkone]

Thank you for the detail.