Skip to content

Migrate filter and search timestamp surfaces to Jiff #787

Description

@danbi2990

Background

TrafficFilter and Filter.period are both filter/search related surfaces with chrono timestamp values. TrafficFilter stores modification timestamps, while Filter.period can store custom search periods containing two DateTime<Utc> values.

Prerequisites

  • Default bincode table value baseline has landed.
  • The table-value implementation umbrella is open and linked.
  • Old-byte fixture coverage for the exact TrafficFilter and Filter.period stored values exists before production type changes are made, or this issue adds that fixture coverage first.

Scope

  • Migrate TrafficFilter.last_modification_time.
  • Migrate TrafficFilter.update_time.
  • Migrate PeriodForSearch::Custom used by Filter.period.
  • Preserve stored bincode compatibility where possible.

Acceptance criteria

  • Old TrafficFilter stored bytes remain readable, or data migration is explicitly implemented.
  • Old Filter.period stored bytes remain readable, or data migration is explicitly implemented.
  • Custom period range semantics are preserved.
  • Public/API impact for filter/search wrappers is visible in tests or compile checks.
  • Any remaining chrono usage in the touched filter/search surfaces is explicitly justified.

Out of scope

  • Event query time filters outside these table values.
  • Final chrono dependency cleanup.

Notes

Related discussion: #733

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

blockedPending another issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions