Skip to content

Remove dead agent roles, prompts, and unused node types #1347

Description

@osilkin98

Context

After removing dead workflow modes (#1346), several agent roles and prompt files become orphaned. Additionally, node types used only by removed modes can be pruned from primitives.py.

Dead agent roles & prompts to remove

Role/Prompt Used exclusively by Evidence
failure_analyst role + prompt research_workflow (removed in #1346) 1 reference in definitions.py
refiner role + prompt refine_workflow (removed in #1346) Only in refine mode
skill_reviewer role + prompt skill_refine_workflow (removed in #1346) Only in skill-refine mode
spec_patcher.md prompt spec_update_workflow (removed in #1346) 1 reference per PR #1302
profiler.md prompt factory profile command (being removed) Backs user profile generation
factory/agents/prompts/frontend_design/ subdirectory 3 frontend-design modes (removed in #1346) Exclusive backing prompts

Unused node types to remove from primitives.py

Node Type Used only by Evidence
SubgraphForkNode parallel_improve_workflow (removed) Community issue #1328
SelectionNode parallel_improve_workflow (removed) Community issue #1328
LLMNode mini-swebench contributed workflow + pruned skillopt Community issue #1328

Also remove handling for these node types from: executor.py, skill_export.py, workflow/__init__.py exports.

What to keep

  • All 8 agent roles used by design/create: researcher, strategist, builder, health_checker, code_reviewer, adversarial_tester, archivist, ceo
  • refactory.md prompt (refactory agent is explicitly kept)
  • spec_annotator.md (supports spec-generate, which design depends on)
  • All static playbook files at factory/agents/playbooks/*.md
  • Update AgentRole enum to remove dead roles

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImproves existing feature/functionality or code quality, does not change behavior of codebasestale

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions