Skip to content

Remove dead infrastructure modules (store.py, strategy.py, insights.py, etc.) #1348

Description

@osilkin98

Context

After removing dead workflow modes (#1346), several infrastructure modules have zero remaining callers. These modules existed solely to support the improve/research/meta experiment lifecycle.

Key finding from research: factory begin/factory finalize/ExperimentStore are NEVER invoked by design/create — the entire experiment lifecycle (begin → build → eval → keep/revert → finalize) is improve/research-mode-only machinery.

Modules to delete

Module Lines Why dead
factory/store.py 752 ExperimentStore — begin/finalize/TSV history, unused by design/create
factory/strategy.py ~200 FEEC classification + stuck detection, improve/research-only
factory/insights.py ~300 Cross-project insights, dead once store.py's callers gone
factory/baseline.py ~150 Eval-data-branch baseline fetch for improve/research
factory/review.py ~200 GitHub PR review-comment poster for keep/revert loop
factory/refine_state.py ~100 Refinement-loop state, refine mode only
factory/digest.py ~200 Cross-project/session activity summarizer
factory/summary.py ~150 Session activity summarizer
factory/registry.py ~200 Global cross-project registry, only called by ExperimentStore
factory/issue.py ~300 GitHub/GitLab issue fetching for --focus (verify design --focus doesn't need it)
factory/backfill_archive.py ~100 Archive/citation backfilling
factory/research_index.py ~100 Research citation index
factory/skill_cache.py ~50 Skill-export caching (verify not used by design/create first)

Modules to KEEP (Akash's PR #1302 marks as actively used)

  • factory/adversarial.py — marked actively used
  • factory/analysis.py — marked actively used
  • factory/checkpoint.py — marked actively used
  • factory/report.py — marked actively used
  • factory/clean_pr.py — marked actively used
  • factory/mempalace/ — marked actively used
  • factory/cycle_analyzer.py — actively imported by outer_loop

Also delete

  • Corresponding test files for removed modules
  • tests/test_store.py, tests/test_strategy.py, tests/test_insights.py, etc.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementImproves existing feature/functionality or code quality, does not change behavior of codebasestale

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions