Possibility of Performance Issue ()

[newfylox]

Hi! Great plugin by the way.

I don't know if it's since the new update, but when I came back in my WP-Admin Widgets page, it took me 3 minutes to fully load the page. Then I did a performance recording with Google Chrome and found that Widget Options plugin was causing the problem.

But then I found that Widget Options had a performance issue ONLY when Posts in sidebar was activated. The problem is gone when I comment Pis.CloneWidget.Bind(); in pis-duplicate.js. Calling Bind with Widget Options is causing the problem but I don't know why.

posts-in-sidebar/assets/pis-duplicate.js

Line 18 in e644e68

Pis.CloneWidget.Bind();

Thanks!

[aldolat]

Hi, @newfylox and thank you for reporting it.

Honestly I suck at JavaScript: as you can see, I took that code from Themesfactory and adapted it to my plugin.
I don't have this problem in my sites, but another user is having (or have had) this problem recently. You can take a look there if you want. I don't know if the problem of that user is related to the one you're reporting here.

Anyway, I have to decide what to do with this JS. I'll let you know.

Thanks again.

[newfylox]

It seems to be a recursive error. The function seems to call itself or at least referencing itself too much times that it grows exponentially.

Lines #⁠23 and #⁠42

posts-in-sidebar/assets/pis-duplicate.js

Lines 22 to 43 in e644e68

	Bind: function () {
	$('#widgets-right').off('DOMSubtreeModified', Pis.CloneWidget.Bind);
	$('*[id*=pis_posts_in_sidebar-]:visible .widget-control-actions:not(.pis-cloneable)').each(function () {
	var $widget = $(this);
	var $clone = $('<a>');
	var clone = $clone.get()[0];
	$clone.addClass('pis-clone-me pis-clone-action')
	.attr('title', pis_js_duplicate_widget.title)
	.attr('href', '#')
	.html(pis_js_duplicate_widget.text);
	$widget.addClass('pis-cloneable');
	$clone.insertAfter($widget.find('.alignleft .widget-control-remove'));
	//Separator |
	clone.insertAdjacentHTML('beforebegin', ' | ');
	});
	$('#widgets-right').on('DOMSubtreeModified', Pis.CloneWidget.Bind);
	},

[aldolat]

Thank you @newfylox.
Do you know if the problem can be resolved in a way?
I would to mantain this feature because a user asked me for that. But if it's a problem, I will remove it immediately.

[newfylox]

@aldolat I didn't take time to analyze your code. Can you explain me by words what the function Bind is supposed to do? What the purpose of this function? I want to know that if I change some stuff, I'm not breaking anything by testing myself.

With more details (and reference to other functions) I could probably push an idea

[aldolat]

I have no idea. As I already wrote here, I do not know JavaScript. I took the entire GPL-licensed JS code from another plugin (see the initial lines in that file) and changed something to adapt the code to Posts in Sidebar.

The scope of the JS, anyway, is to let users to duplicate a widget, so that they don't have to set all the options again.

[newfylox]

Yeah sorry I should have read more carefully.

Ok right I'm a bit busy but I'll try something soon for sure. I'll keep you in touch.

[aldolat]

Thank you in advance! :-)