diff --git a/plugins/ship-check/agents/bug-checker.md b/plugins/ship-check/agents/bug-checker.md index 25e89a1..5ff02f9 100644 --- a/plugins/ship-check/agents/bug-checker.md +++ b/plugins/ship-check/agents/bug-checker.md @@ -136,14 +136,15 @@ skipping decision points. Every PR comment or review you post โ€” inline comments, review bodies, PR-level comments โ€” MUST include the footer: `\n\n---\n*๐Ÿ” ship-check ยท bug-check ยท *` -where `` is your verified exact runtime model ID, including version and -variant suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess -it. In Codex, when visible system prose is generic, use a runtime-provided current -thread or session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. No exceptions โ€” a comment without a footer misattributes -automated output to the repo owner. +where `` identifies the runtime model. Claude runs use the family ID from +system context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. No exceptions โ€” a comment without a footer misattributes automated +output to the repo owner. ### Comment mode diff --git a/plugins/ship-check/agents/code-quality-reviewer.md b/plugins/ship-check/agents/code-quality-reviewer.md index 192f6bb..4d9bddc 100644 --- a/plugins/ship-check/agents/code-quality-reviewer.md +++ b/plugins/ship-check/agents/code-quality-reviewer.md @@ -116,14 +116,15 @@ You loaded `sequentialthinking` in orientation. Call it at these decision points Every PR comment or review you post โ€” inline comments, review bodies, PR-level comments โ€” MUST include the footer: `\n\n---\n*๐Ÿ” ship-check ยท code-quality ยท *` -where `` is your verified exact runtime model ID, including version and -variant suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess -it. In Codex, when visible system prose is generic, use a runtime-provided current -thread or session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. No exceptions โ€” a comment without a footer misattributes -automated output to the repo owner. +where `` identifies the runtime model. Claude runs use the family ID from +system context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. No exceptions โ€” a comment without a footer misattributes automated +output to the repo owner. ### Comment mode diff --git a/plugins/ship-check/agents/pr-reviewer.md b/plugins/ship-check/agents/pr-reviewer.md index 34b42f7..91bdf8a 100644 --- a/plugins/ship-check/agents/pr-reviewer.md +++ b/plugins/ship-check/agents/pr-reviewer.md @@ -126,14 +126,15 @@ you're shortcutting the review. Every PR comment or review you post โ€” inline comments, review bodies, PR-level comments โ€” MUST include the footer: `\n\n---\n*๐Ÿ” ship-check ยท pr-review ยท *` -where `` is your verified exact runtime model ID, including version and -variant suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess -it. In Codex, when visible system prose is generic, use a runtime-provided current -thread or session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. No exceptions โ€” a comment without a footer misattributes -automated output to the repo owner. +where `` identifies the runtime model. Claude runs use the family ID from +system context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. No exceptions โ€” a comment without a footer misattributes automated +output to the repo owner. ### Comment mode diff --git a/plugins/ship-check/agents/test-auditor.md b/plugins/ship-check/agents/test-auditor.md index 67eff20..76ede99 100644 --- a/plugins/ship-check/agents/test-auditor.md +++ b/plugins/ship-check/agents/test-auditor.md @@ -98,14 +98,15 @@ You loaded `sequentialthinking` in orientation. Call it at these decision points Every PR comment or review you post โ€” inline comments, review bodies, PR-level comments โ€” MUST include the footer: `\n\n---\n*๐Ÿ” ship-check ยท test-audit ยท *` -where `` is your verified exact runtime model ID, including version and -variant suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess -it. In Codex, when visible system prose is generic, use a runtime-provided current -thread or session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. No exceptions โ€” a comment without a footer misattributes -automated output to the repo owner. +where `` identifies the runtime model. Claude runs use the family ID from +system context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. No exceptions โ€” a comment without a footer misattributes automated +output to the repo owner. ### Comment mode diff --git a/plugins/ship-check/skills/bug-check/SKILL.md b/plugins/ship-check/skills/bug-check/SKILL.md index b49fe7d..81bc4de 100644 --- a/plugins/ship-check/skills/bug-check/SKILL.md +++ b/plugins/ship-check/skills/bug-check/SKILL.md @@ -538,13 +538,14 @@ REVIEW ``` Replace `OWNER_REPO` and `PR_NUMBER` with values from the dispatch prompt. Replace -`MODEL_ID` with your verified exact runtime model ID, including version and variant -suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess it. In -Codex, when visible system prose is generic, use a runtime-provided current thread or -session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. +`MODEL_ID` with the runtime model label. Claude runs use the family ID from system +context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. 5. **If 0 findings and no dismissals**, skip the API call โ€” report "0 findings" to the orchestrator only. With 0 findings but cleared suspicions, post a diff --git a/plugins/ship-check/skills/code-quality/SKILL.md b/plugins/ship-check/skills/code-quality/SKILL.md index 72f62ef..51db469 100644 --- a/plugins/ship-check/skills/code-quality/SKILL.md +++ b/plugins/ship-check/skills/code-quality/SKILL.md @@ -490,13 +490,14 @@ REVIEW ``` Replace `OWNER_REPO` and `PR_NUMBER` with values from the dispatch prompt. Replace -`MODEL_ID` with your verified exact runtime model ID, including version and variant -suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess it. In -Codex, when visible system prose is generic, use a runtime-provided current thread or -session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. +`MODEL_ID` with the runtime model label. Claude runs use the family ID from system +context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. 4. **If 0 findings and no dismissals**, skip the API call โ€” report "0 findings" to the orchestrator only. With 0 findings but cleared suspicions, post a diff --git a/plugins/ship-check/skills/pr-monitor/SKILL.md b/plugins/ship-check/skills/pr-monitor/SKILL.md index 9459ccc..cee52e8 100644 --- a/plugins/ship-check/skills/pr-monitor/SKILL.md +++ b/plugins/ship-check/skills/pr-monitor/SKILL.md @@ -235,16 +235,14 @@ For each unresolved bot thread, do ALL of these in order: 4. **Reply to the comment** -- do this BEFORE resolving, for EVERY bot comment. Since `gh` posts as the user's account, every reply MUST include an attribution - footer. Use the exact runtime model ID, including its version and variant suffixes - (for example, `gpt-5.6-sol`). Never shorten it to a family label such as `gpt-5`, - translate it to a display name, or guess. Read it from runtime system context. In - Codex, when the visible system prose is generic, first obtain the current thread or - session ID from runtime-provided task metadata, then match it exactly to - `session_meta.payload.id` in the rollout metadata and read - `session_meta.payload.base_instructions.provenance.model`. Never select a rollout - by recency, cwd, or display name. If the runtime does not expose the current ID or - no exact model ID can be verified, stop before posting and report the attribution - blocker. The footer format is: + footer. Claude runs use the family ID from system context, such as + `claude-opus-4-6`; omit context-window, dated-build, and other transcript-only + suffixes. Codex GPT runs use the verified exact runtime model ID, including version + and variant suffixes such as `gpt-5.6-sol`. In Codex, match a runtime-provided + current thread or session ID to `session_meta.payload.id` exactly, then read + `session_meta.payload.base_instructions.provenance.model`; never select a rollout + by recency, cwd, or display name. If the Codex ID cannot be verified, stop before + posting and report the attribution blocker. The footer format is: `\n\n---\n*๐Ÿ” ship-check ยท pr-monitor ยท *` ``` diff --git a/plugins/ship-check/skills/pr-review/SKILL.md b/plugins/ship-check/skills/pr-review/SKILL.md index ddd9404..c2b9411 100644 --- a/plugins/ship-check/skills/pr-review/SKILL.md +++ b/plugins/ship-check/skills/pr-review/SKILL.md @@ -270,13 +270,14 @@ REVIEW ``` Replace `OWNER_REPO` and `PR_NUMBER` with values from the dispatch prompt. Replace -`MODEL_ID` with your verified exact runtime model ID, including version and variant -suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess it. In -Codex, when visible system prose is generic, use a runtime-provided current thread or -session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. +`MODEL_ID` with the runtime model label. Claude runs use the family ID from system +context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. 5. **If 0 findings and no dismissals**, skip the API call โ€” report "0 findings" to the orchestrator only. With 0 findings but cleared suspicions, post a diff --git a/plugins/ship-check/skills/ship-check/SKILL.md b/plugins/ship-check/skills/ship-check/SKILL.md index 4777707..50e60b1 100644 --- a/plugins/ship-check/skills/ship-check/SKILL.md +++ b/plugins/ship-check/skills/ship-check/SKILL.md @@ -45,20 +45,18 @@ orchestrator triage, pr-monitor replies). - `` is the phase or role: `pr-review`, `code-quality`, `test-audit`, `bug-check`, `pr-monitor`, or `triage` (for orchestrator inter-phase triage posts). -- `` is the poster's exact runtime model ID, including version and variant - suffixes (for example, `gpt-5.6-sol`). Never shorten it to a family label such as - `gpt-5`, translate it to a display name, or guess. Read it from runtime system - context. In Codex, when visible system prose is generic, first obtain the current - thread or session ID from runtime-provided task metadata, match it exactly to - `session_meta.payload.id` in the rollout metadata, then read - `session_meta.payload.base_instructions.provenance.model`. Never select a rollout by - recency, cwd, or display name. If the runtime does not expose the current ID or no - exact model ID can be verified, stop before posting and report the attribution - blocker. Agents self-identify โ€” the orchestrator does not look up or pass model IDs - for them. +- `` identifies the poster's runtime model. Claude runs use the family ID + from system context, such as `claude-opus-4-6`; omit context-window, dated-build, + and other transcript-only suffixes. Codex GPT runs use the verified exact runtime + model ID, including version and variant suffixes such as `gpt-5.6-sol`. In Codex, + match a runtime-provided current thread or session ID to `session_meta.payload.id` + exactly, then read `session_meta.payload.base_instructions.provenance.model`; never + select a rollout by recency, cwd, or display name. If the Codex ID cannot be + verified, stop before posting and report the attribution blocker. Agents + self-identify โ€” the orchestrator does not look up or pass model IDs for them. - **The orchestrator's own PR-level comments** (non-inline findings, deferred items - posted via `gh pr comment`) use the orchestrator's own verified exact runtime model - ID with component `triage` or `ship-check`. + posted via `gh pr comment`) follow the same runtime-specific model-label rule with + component `triage` or `ship-check`. A comment posted without a footer is indistinguishable from the repo owner's manual comments and misattributes automated output to a human. Every `gh api` and @@ -78,8 +76,7 @@ commit): When committing, add this trailer to every commit message (after the body, before any trailers the harness adds): Ship-Check: PHASE_NAME ยท YOUR_MODEL_ID -Use your verified exact runtime model ID for YOUR_MODEL_ID. Preserve version and -variant suffixes; never abbreviate, translate, or guess it. +Use the runtime-specific model label defined above for YOUR_MODEL_ID. ``` The harness appends its own `Co-Authored-By` trailer automatically; the `Ship-Check` @@ -130,9 +127,8 @@ and post them as a single GitHub PR review with inline comments. Follow the "Com mode" section in your preloaded skill for the gh api template. Only post a review if you have findings โ€” skip the API call for 0 findings. Repo: OWNER_REPO -Append a footer to the review body AND every inline comment body using your own -exact runtime model ID, including version and variant suffixes. Never abbreviate, -translate, or guess it: +Append a footer to the review body AND every inline comment body using the +runtime-specific model label from the Attribution section: \n\n---\n*๐Ÿ” ship-check ยท PHASE_NAME ยท YOUR_MODEL_ID* ``` @@ -180,7 +176,7 @@ gh repo view --json nameWithOwner -q .nameWithOwner ``` Pass it as `Repo: owner/repo` in the dispatch prompt. In comment mode, agents -include their own verified exact runtime model ID in the footer โ€” +include their own runtime-specific model label in the footer โ€” the orchestrator does not need to look it up or pass it. ## Local review mode (`--local`) @@ -368,8 +364,7 @@ Append it to every phase that commits (phases 1, 3-5): ``` When committing, add this trailer to every commit message: Ship-Check: PHASE_NAME ยท YOUR_MODEL_ID -Use your verified exact runtime model ID for YOUR_MODEL_ID. Preserve version and -variant suffixes; never abbreviate, translate, or guess it. +Use the runtime-specific model label from the Attribution section for YOUR_MODEL_ID. ``` ### Phase 1: PR Review diff --git a/plugins/ship-check/skills/test-audit/SKILL.md b/plugins/ship-check/skills/test-audit/SKILL.md index 253f2be..3f4c80d 100644 --- a/plugins/ship-check/skills/test-audit/SKILL.md +++ b/plugins/ship-check/skills/test-audit/SKILL.md @@ -386,13 +386,14 @@ REVIEW ``` Replace `OWNER_REPO` and `PR_NUMBER` with values from the dispatch prompt. Replace -`MODEL_ID` with your verified exact runtime model ID, including version and variant -suffixes (for example, `gpt-5.6-sol`). Never abbreviate, translate, or guess it. In -Codex, when visible system prose is generic, use a runtime-provided current thread or -session ID to match `session_meta.payload.id` exactly, then read -`session_meta.payload.base_instructions.provenance.model`. Never select a rollout by -recency, cwd, or display name. If the current ID or exact model ID cannot be verified, -stop before posting. +`MODEL_ID` with the runtime model label. Claude runs use the family ID from system +context, such as `claude-opus-4-6`; omit context-window, dated-build, and other +transcript-only suffixes. Codex GPT runs use the verified exact runtime model ID, +including version and variant suffixes such as `gpt-5.6-sol`. In Codex, match a +runtime-provided current thread or session ID to `session_meta.payload.id` exactly, +then read `session_meta.payload.base_instructions.provenance.model`; never select a +rollout by recency, cwd, or display name. If the Codex ID cannot be verified, stop +before posting. 4. **If 0 findings and no dismissals**, skip the API call โ€” report "0 findings" to the orchestrator only. With 0 findings but cleared suspicions, post a