Skip to content

Incorrect type annotation for encoder aggregation #67

@david-waterworth

Description

@david-waterworth

The constructor of Seq2Seq defines aggregations as a str, but the forward method treats it as a sequence, and the jsonnet file splits from a comma-separated string to an array. I'm not sure if something has changed in allennlp, but for me, this results in an exception that it's expecting aggregations to be a string.

def __init__(self, architecture: Seq2SeqEncoder, aggregations: str) -> None:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions