DGGRIDv8: `grid_cell_polygons_from_cellids` and `grid_cell_centroids_from_cellids` not returning correct zone IDs and geometries.

[tik65536]

@fmigneault ,

DGGRIDv8 :
When using the functions grid_cell_polygons_from_cellids and grid_cell_centroids_from_cellids with address parameters as follows:

address_params = {
            'input_address_type': 'HIERNDX',
            'input_hier_ndx_system': 'Z7',
            'input_hier_ndx_form': 'DIGIT_STRING',
            'output_address_type': 'HIERNDX',
            'output_cell_label_type': 'OUTPUT_ADDRESS_TYPE',
            'output_hier_ndx_system': 'Z7',
            'output_hier_ndx_form': 'DIGIT_STRING'
}

The result zone ID and geometry are not correct. For example :

centroids_gdf = dggridv8.grid_cell_polygons_from_cellids(['0213624'], 'IGEO7', resolution=5, **address_params)

It is found that the metafile is missing the input_hier_ndx_form DIGIT_STRING, so it uses INT64 (by default).

The metafiles are attached for reference:

metafile_working.txt

metafile_notworking.txt

[tik65536]

@fmigneault, I fixed the issue in the dgapi_grid_gen function by applying the exact handling of self.output_extra_fields to self.input_extra_files, like the following :

line 933

        if 'input_address_type' in subset_conf.keys() and subset_conf.get('input_address_type', 'NOPE') in self.input_address_types:
            metafile.append("input_address_type " + subset_conf['input_address_type'])
            for elem in self.input_extra_fields:
                if elem in subset_conf:
                    metafile.append(f"{elem} {subset_conf[elem]}")

I have tested it and it's working.

[fmigneault]

@tik65536 Thanks for the report. I'll check why it doesn't make its way to the metafile.

[allixender]

@fmigneault How can this still happen that parameters are "forgotten" to to put into the metafile? Aren't we by now aware what paramters exists and we can check programmatically?

[fmigneault]

It is because all parameters are not systematically added. Most of the code does many pre-checks and adds specific elements based on various conditions to ensure consistency with the operation and the selected DGGRS. This was the same in previous versions, but because input_address_type was always added as is with Z7_STRING directly, the other side-car parameters were never considered in the first place.

[tik65536]

The issue was fixed in PR #36 and #38.