fix(ol): correct checkpoint DA and inbox indexes#1801
Closed
voidash wants to merge 1 commit into
Closed
Conversation
Contributor
|
Commit: 25ac030 SP1 Execution Results
|
Member
|
@codex review this pr |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1801 +/- ##
==========================================
- Coverage 78.95% 78.90% -0.05%
==========================================
Files 655 655
Lines 71268 71309 +41
==========================================
Hits 56268 56268
- Misses 15000 15041 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strataprover dependencies that became unused after sharing the checkpoint DA helperBug / context
This addresses the Slack-reported OL prover failure under STR-3412:
DA witness does not match authenticated preseal state root: ChainIntegrityThe old prover input path built DA by replaying full OL blocks through
DaAccumulatingState. Full replay includes L1 manifest processing, so deposits, limbo deposits, or predicate-key updates could be included in the DA blob. The checkpoint proof verifies the DA blob against the terminal block'spreseal_state_root, which is taken before manifest processing. In those cases the witness describedepoch_start -> post-manifest, while the proof expectedepoch_start -> preseal.The inbox index fix is a separate local e2e finding:
get_inbox_messageswas derivingnext_inbox_msg_idxfrom the block before the range instead of the last block in the returned range.Verification
cargo fmt --check -p strata -p strata-ol-checkpoint -p alpen-ee-sequencergit diff --checkCARGO_INCREMENTAL=0 cargo check -p strata-ol-checkpoint --libCARGO_INCREMENTAL=0 cargo check -p strata --features prover --no-default-featuresCARGO_INCREMENTAL=0 cargo check -p alpen-ee-sequencer --lib