-
Notifications
You must be signed in to change notification settings - Fork 27
fix(ci): repair EE spec test workflows #1836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
voidash
wants to merge
8
commits into
main
Choose a base branch
from
fix/ee-spec-ci-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5141526
fix(ci): repair EE spec test workflows
voidash 50253b5
fix(ci): assert EEST proof pipeline
voidash adf4a47
fix(ci): preserve EEST log baseline paths
voidash 850fe4b
fix(ci): avoid pipefail false negatives in EEST assertion
voidash 7e79a7b
fix(ci): run eest against execution-only client
voidash 0555f23
fix(ci): clear eest clippy warnings
voidash a7937e5
fix(ci): assert eest proofs through rpc
voidash 4d6715a
fix(ci): assert eest through full stack
voidash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole purpose of this entire pipeline, at least the way I designed it, was to have our EE proofs (for now, chunk proofs) to be generated against the EF tests load (e.g. against the blocks with all these crazy transactions).
without this, we are quite literally testing pure Reth EVM against EF tests (which is pointless).
IMO, the essense of the effort should be directed towards restoring that logic (and re-adopting it for chunk proofs).