fix(evm-ee): persist created bytecodes during chunk replay#1848
Closed
irnb wants to merge 1 commit into
Closed
Conversation
Contributor
|
Commit: 6eee20c SP1 Execution Results
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1848 +/- ##
==========================================
+ Coverage 79.76% 79.77% +0.01%
==========================================
Files 674 674
Lines 74805 74838 +33
==========================================
+ Hits 59665 59699 +34
+ Misses 15140 15139 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
AccessedStateGeneratorrecords bytecodes that are read from state during block execution. Contract creation is different: the runtime bytecode is produced as a write inexecution_output.state.contracts.EE chunk replay merged the account/storage trie changes after each block, so a newly-created contract account and its
code_hashbecame visible to later blocks in the same chunk. However, replay discarded the created bytecode itself.The fix carries created bytecodes through
EvmWriteBatchand inserts them intoEvmPartialStateafter the block is replayed.Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
If yes, please add relevant links:
Checklist
Related Issues