From 1197d925a607d54d9321cce695b8b3bfeeaf39fc Mon Sep 17 00:00:00 2001 From: Christopher Costa Date: Mon, 27 Apr 2026 15:59:23 +0100 Subject: [PATCH] Review VITE BASE URL for integration --- .github/workflows/ambar-task-explorer.yaml | 8 ++++++++ task-explorer/package.json | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ambar-task-explorer.yaml b/.github/workflows/ambar-task-explorer.yaml index f426429..d6a2081 100644 --- a/.github/workflows/ambar-task-explorer.yaml +++ b/.github/workflows/ambar-task-explorer.yaml @@ -128,6 +128,7 @@ jobs: platforms: linux/amd64,linux/arm64 build-args: | GITHUB_TOKEN=${{ secrets.READ_ACCESS_TO_REPOS }} + VITE_BASE_PATH=/tasks/ cache-from: type=gha,scope=task-explorer cache-to: type=gha,mode=max,scope=task-explorer @@ -148,7 +149,14 @@ jobs: tags: | ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.version.outputs.value }} + # VITE_BASE_PATH is baked into the frontend bundle at build time + # (Vite emits absolute /tasks/assets/... refs and TanStack Router + # uses BASE_URL as its basepath). The published image is therefore + # locked to serving at /tasks. AmbarCLI's task-explorer module + # default basePath matches; tenants who override it will get a + # blank page — see ambar_tools registry comment. build-args: | GITHUB_TOKEN=${{ secrets.READ_ACCESS_TO_REPOS }} + VITE_BASE_PATH=/tasks/ cache-from: type=gha,scope=task-explorer cache-to: type=gha,mode=max,scope=task-explorer diff --git a/task-explorer/package.json b/task-explorer/package.json index 0fe90c8..490c627 100644 --- a/task-explorer/package.json +++ b/task-explorer/package.json @@ -1,7 +1,7 @@ { "name": "task-explorer", "private": true, - "version": "0.1.1", + "version": "0.1.2", "scripts": { "dev:frontend": "pnpm --filter './frontend' dev -- --host 0.0.0.0", "dev:api": "pnpm --filter './backend' dev",