ADR-019: Unified Workspace Filtering & Aggregate Metrics — Tracking Issue

[amiable-dev]

Summary

Tracking issue for ADR-019 implementation. Introduces shared device + mode filters between Signal Flow and Events panels, collapsible filter panes, link/unlink toggle, reusable filter components, aggregate metrics store for compact mode, and unmapped event tagging.

ADR: ADR-019-unified-workspace-filtering-and-aggregate-metrics.md
Mockups: signal-flow-v3-mockups.html (tabs S3, S4, Combined)
Total Estimate: 27–37 hours across 7 phases

Decisions

#	Decision	Status
D1	Three-Tier Filter Architecture (shared / panel-local / view-specific)	🔲
D2	Link/Unlink Toggle with visual indicator	🔲
D3	Collapsible Unified Filter Pane	🔲
D4	Promote DeviceStatusPills to shared filter widget	🔲
D5	Mode Filter — new shared control	🔲
D6	Extract TypeFilterChips reusable component	🔲
D7	Remove eventDeviceFilter store (breaking change)	🔲
D8	Aggregate Metrics Store (signalFlowMetrics.js)	🔲
D9	Signal Flow consumes signalPulseStore directly	🔲
D10	Unmapped Events — filter chip in Signal Flow	🔲
D11	Keyboard Shortcuts (F, Shift+F, D, L, 0–9)	🔲
D12	Events Sidebar — mode indicator + unmapped tagging	🔲

Phase Breakdown

Phase 1: Shared Filter Store & Migration (6–8h)

• 1A: Create workspaceFilters.js shared filter store → D1, D2
• 1B: Migrate DeviceStatusPills to activeDeviceFilter with multi-select → D4, D7
• 1C: Migrate filteredEvents to Set-based device filter, remove eventDeviceFilter → D7

Phase 2: Collapsible Filter Panes (4–6h)

• 2A: FilterSummaryBar component + collapse state persistence → D3
• 2B: Wire collapsible panes in Events + Signal Flow → D3, D11

Phase 3: Link/Unlink Toggle (3–4h)

• 3A: LinkToggle component + link/unlink state machine → D2, D11

Phase 4: Type Filter Component & Mode Filter (4–5h)

• 4A: Extract TypeFilterChips reusable component → D6, D10
• 4B: Shared mode filter with live/pinned indicator → D5, D12.1

Phase 5: Aggregate Metrics Store (4–6h)

• 5A: Create signalFlowMetrics.js derived store → D8, D9
• 5B: Wire compact mode UI to deviceMetrics → D8

Phase 6: Events Sidebar Enhancements (3–4h)

• 6A: Unmapped event tagging in Events stream → D12.2

Phase 7: Integration Testing (3–4h)

• 7A: Integration tests + regression verification → All

Dependency Graph

1A ──→ 1B ──→ 1C
 │      │
 ├──→ 2A ──→ 2B
 │
 ├──→ 3A
 │
 ├──→ 4A
 ├──→ 4B
 │
 ├──→ 5A ──→ 5B
 │
 └──→ 6A (also depends on 1C, 4B)
                    ↓
                   7A (depends on all)

Phases 2 and 3 can run in parallel after Phase 1.
Phases 4 and 5 can run in parallel.
Phase 6 depends on Phase 1 and Phase 4.

External Dependencies

• ADR-015 Phase 2 (Signal Pulse): signalPulseStore for runtime metrics in compact mode. Without it, Phase 5 shows structural metrics only (graceful degradation).
• ADR-014 (Mapping Feedback): mappingFireState / mappingFireCount — unchanged, consumed by Signal Flow expanded view.
• ADR-017 (Unified Mapping): + Map CTA on unmapped rows opens MappingEditor.

[amiable-dev]

Update: #583 Phase A (Static Track Diagram) is Complete

Context: The Signal Flow workspace view (#583 Phase A) has been built. ADR-019 issues were authored before this was confirmed, so several issues referenced Signal Flow components as "to be created."

Revised Sequencing

ADR-019 is now a retrofit into an existing Signal Flow view, not building against a blank slate:

#583 Phase A (static track diagram) ✅ COMPLETE
       ↓
ADR-019 Phase 1 (shared filter stores — retrofit into existing SF view)
       ↓
#583 Phase B (live animation) ← can run in parallel with ADR-019 Phases 2-5
       ↓
#583 Phase C (interactions) ← benefits from ADR-019 Phase 1 for cross-panel sync
       ↓
#568 Section 4C (Chat bridge)
       ↓
#569 (deferred follow-up)

Affected Issues

Issue	Change
1A	Audit existing SF local state to replace with shared stores
1B	Check if SF already uses DeviceStatusPills or has own device interactions
2B	Wire into existing SF toolbar (not "to be created")
3A	Place LinkToggle in existing SF toolbar
4B	Add mode selector to existing SF toolbar
5B	Compact mode may need creation within existing view; dependency partially met

Parallelisation Opportunity

With #583 Phase A done, ADR-019 Phase 1 can start immediately. #583 Phases B–C can run in parallel with ADR-019 Phases 2–7 since they touch different concerns (live animation/interactions vs. filter architecture/metrics stores).

[amiable-dev]

Update: #583 (all phases) and #568 are merged

Closed issues:

• Signal Flow: Workspace Track Diagram View #583 Signal Flow Workspace Track Diagram — CLOSED (PR feat(gui): Signal Flow workspace view — Phase A static layout #595: Phase A, PR feat(gui): Signal Flow Phases B & C — live animation, loop arcs, cross-track routing (#583) #629: Phases B+C). 125 tests passing.
• [ADR-016] Chunk 4: Performance Mode, prompt engineering, and Signal Flow bridge #568 ADR-016 Chunk 4: Performance Mode + Chat Bridge — CLOSED (PR feat: conversational integration & performance mode (ADR-016 Chunk 4, #568) #628 + PR feat(gui): Signal Flow Phases B & C — live animation, loop arcs, cross-track routing (#583) #629). 27 tests.
• [ADR-016] Chunk 5: Token budget optimisation and multi-provider testing #569 ADR-016 Chunk 5: Token Budget + Multi-Provider — OPEN (dependencies now met).

What exists now

Signal Flow is a fully interactive workspace view with:

• SignalFlowView.svelte — main view, toolbar, track container
• TrackRow.svelte — per-device horizontal track with rail, junctions, branches
• TrackJunction.svelte — mapping junction nodes with fired pulse animation
• LoopArc.svelte — amber/red feedback loop return arcs with warning badges
• CrossTrackConnector.svelte — dashed SVG cross-track routing
• Event dot animation along rails (pooled, max 8 per track)
• Channel activity bars (2-second rolling average)
• Unmapped terminus dots (dimmed, clickable → Chat)
• signalFlowAction store — bridges clicks to Chat input pre-population
• Performance Mode — /performance command, PERF badge, signalContextStore.settings
• SIGNAL_FLOW in WORKSPACE_VIEWS

ADR-019 is now a retrofit

All ADR-019 work integrates into this existing, tested, interactive view:

#583 Phases A+B+C ✅ MERGED (PR #595, #629)
#568 Sections 4A+4B+4C ✅ MERGED (PR #628, #629)
       ↓
ADR-019 Phase 1 (shared filter stores — retrofit into existing SF view)
       ↓
ADR-019 Phases 2–7 (collapse, link, type chips, mode, metrics, unmapped)
       ↓
#569 (token budget + multi-provider — unblocked, independent)

Per-issue impact summary

Issue	Impact
1A	Audit SF local state to replace with shared stores. signalFlowAction (Chat bridge) is independent — leave it.
1B	Scope increase: migrate both Events and Signal Flow device interactions to activeDeviceFilter. Don't break Chat bridge click handlers.
2B	"SF view to be created" → Wire into existing toolbar. Preserve Phase C interaction handlers.
3A	Place LinkToggle in existing toolbar. Device interactions propagate via shared store when linked.
4B	Add mode selector to existing toolbar. Junctions and loop detection must respect mode filter.
5B	Expanded view exists. Compact mode (aggregate summary) is a new density view within existing SignalFlowView.
6A	Unmapped terminus dots exist in SF. Check for shared computation with Events _unmapped flag.
7A	125 SF tests + 27 Chat bridge tests = baseline. ADR-019 tests must not regress these.

Test baseline

Suite	Count	Source
Signal Flow	125	PR #595, #629
Chat bridge / Performance Mode	27	PR #628, #629
Events (existing)	existing	Pre-ADR-019
EventFilter (existing)	existing	Pre-ADR-019

[amiable-dev]

Cross-reference: ADR-022

ADR-022 extends ADR-019's completed infrastructure with:

A4.1: DeviceStatusPills → BindingPills — Component rename, +N unbound badge, protocol icons. Implemented in ADR-022 Phase 2.

A4.2: Unbound Sources concept — New filter option distinguishing "unbound" (no binding) from "unmapped" (bound but no matching rule). UnboundSourcesGroup in Signal Flow. Implemented in ADR-022 Phase 2.

All ADR-019 phases remain closed. These are additive extensions built on ADR-019's infrastructure.

See: ADR-022-amendments-to-existing-adrs.md Amendment 4