-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Context
ADR-019 (Unified Workspace Filtering & Aggregate Metrics) is fully implemented across all 7 phases (#633–#644). Three minor UX polish items from the spec remain unimplemented.
Gaps
1. Numeric device quick-select shortcuts (D11)
ADR-019 D11 specifies 1–9 to quick-select a device by index and 0 to select all devices when the filter pane is expanded. Not currently implemented in any component.
2. Auto-collapse at <500px (D3)
ADR-019 D3 specifies: "when workspace width drops below 500px, auto-collapse to summary and switch to compact density." No width-based responsive logic exists — manual collapse works fine.
3. F / Shift+F standalone keyboard shortcuts (D11)
ADR-019 D11 specifies F to toggle Signal Flow filter collapse and Shift+F to toggle Events filter collapse when those containers are focused. These may only work via FilterSummaryBar click handlers, not as standalone key handlers on the focused container.
Acceptance Criteria
- Pressing
1–9when filter pane is expanded selects the Nth device;0selects all - Signal Flow filter toolbar auto-collapses when workspace width < 500px and switches to compact density
-
Fkey toggles Signal Flow filter expand/collapse when workspace is focused -
Shift+Ftoggles Events filter expand/collapse when Events sidebar is focused - Shortcuts only fire when the relevant container has focus (not during chat input or mapping editing)
Priority
Low — these are UX polish items, not architectural gaps. Core filtering, shared stores, link/unlink, aggregate metrics, and cross-panel integration are all working.
References
- ADR-019:
docs/adrs/ADR-019-unified-workspace-filtering-and-aggregate-metrics.md - D3 (Collapsible Unified Filter Pane)
- D11 (Keyboard Shortcuts)