Summary
Add more branch coverage around the LCP license HTTP client, especially the non-happy-path behavior for license fetch and revoke requests.
Why this matters
This package sits on an important integration seam, and better tests here would make refactors safer without requiring deep knowledge of the whole codebase.
Suggested files
internal/lcp/license/license.go
internal/lcp/license/license_client_test.go
Acceptance criteria
- Tests cover at least one failing
GetLicense fallback path.
- Tests cover at least one
RevokeLicense error path beyond the existing soft-404 case.
- Tests use
httptest and do not depend on external services.
go test ./... passes.
Nice to have
- Keep the test server setup easy to read for first-time contributors.
Summary
Add more branch coverage around the LCP license HTTP client, especially the non-happy-path behavior for license fetch and revoke requests.
Why this matters
This package sits on an important integration seam, and better tests here would make refactors safer without requiring deep knowledge of the whole codebase.
Suggested files
internal/lcp/license/license.gointernal/lcp/license/license_client_test.goAcceptance criteria
GetLicensefallback path.RevokeLicenseerror path beyond the existing soft-404 case.httptestand do not depend on external services.go test ./...passes.Nice to have