fix: include experiment key on local-eval exposure events#46
Merged
Conversation
Local evaluation exposure events emit `metadata["experimentKey"]` inside the metadata blob but never lift it onto a top-level event property. Custom reports keying off `[Experiment] Experiment Key` therefore see no value for customers using local evaluation. When `variant.Metadata["experimentKey"]` is present, set `EventProperties["[Experiment] Experiment Key"]`. Mirrors the equivalent fix in the Node SDK (amplitude/experiment-node-server#83). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
kyeh-amp
approved these changes
May 7, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2026
## [1.11.1](v1.11.0...v1.11.1) (2026-05-08) ### Bug Fixes * include experiment key on local-eval exposure events ([#46](#46)) ([dc85e36](dc85e36)), closes [amplitude/experiment-node-server#83](amplitude/experiment-node-server#83)
|
🎉 This PR is included in version 1.11.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toExposureEventscarriedexperimentKeyonly inside themetadatablob — the top-level event property[Experiment] Experiment Keywas never set, so custom reports keying off it saw no value for local-eval customers.variant.Metadata["experimentKey"]is a non-empty string, setEventProperties["[Experiment] Experiment Key"]. Additive and backwards-compatible —metadata,[Experiment] Flag Key,[Experiment] Variant, user properties, andInsertIDare unchanged.Test plan
with_experiment_keyfixture toTestToExposureEvents. Asserts[Experiment] Experiment Keyequals"exp-1"for that flag and is absent for the others.go test ./pkg/experiment/local/ -run TestToExposureEvents -v— passes.🤖 Generated with Claude Code
Note
Low Risk
Low risk: additive change that only sets an extra event property when
variant.Metadata["experimentKey"]is present; existing event fields and filtering behavior are unchanged.Overview
Local evaluation exposure tracking now lifts
variant.Metadata["experimentKey"]into a top-level Amplitude event property ([Experiment] Experiment Key) intoExposureEvents, instead of leaving it only inside themetadatablob.Tests were updated with a
with_experiment_keyfixture to assert the new property is set only when provided, and the expected event count was adjusted accordingly.Reviewed by Cursor Bugbot for commit bcbd125. Bugbot is set up for automated code reviews on this repo. Configure here.