Skip to content

chore(gitignore): add .surfpool/ to workspace-root .gitignore #292

Description

@prasanna-anchorage

Follow-up from #202 (and unaddressed by stacked #285, #289).

What

Surfpool writes a .surfpool/ state directory at its working directory. The integration tests don't set Command::current_dir(...) for the subprocess (solana_test_utils/src/surfpool/manager.rs around line 56), so when tests run via `cargo test` from the repo root, `.surfpool/` lands at the repo root and shows up in `git status` as untracked.

The original Copilot feedback on #202 flagged this; the response was to remove a per-crate `.gitignore` (the one at `src/solana_test_utils/.gitignore`, which only covered the case where tests ran with CWD = `solana_test_utils/`). But the actual fix — adding `.surfpool/` to the workspace-root `.gitignore` — was never applied.

Where

`/.gitignore` (currently contains only `**/target`, `out`, `.DS_Store`, `target`, `*.log`).

Suggested fix

Append `.surfpool/` to the workspace root `.gitignore`.

Or, structurally cleaner: pass `.current_dir()` to the surfpool `Command` so its state lives in a directory the test owns and can tear down.

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions