Skip to content

solana: migrate neutral_trade + onre_app off push_arg_fields; adopt core::arg_rendering corpus-wide #402

Description

Problem

neutral_trade and onre_app still render program-call args via the recursive push_arg_fields on main. That is the same bug #387 fixed for dflow_aggregator:

  • Charset — compact-JSON object rendering can emit "/\, which SignablePayload::validate_charset rejects.
  • Field explosion — byte arrays (e.g. [u8; 32] seeds, opaque IDs) expand into one field per byte, burying the meaningful args.

#375 added crate::core::arg_rendering::format_arg_value (the centralized version of #387's renderer) but applied it only to new presets — existing presets were intentionally left untouched to keep #375 additive (bootstrap-then-own).

Task

Acceptance criteria

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions