Skip to content

Add check max_steps > convergence_steps for celerite_engine #79

Description

@andresgur

tinygp, celerite2 engines already check this

num_iterations = int(max_steps / converge_steps)

        if num_iterations < 1:
            raise ValueError(
                f"max_steps ({max_steps}) must be at least as large as converge_steps ({converge_steps}) to run at least one iteration."
            )

So we just need the same logic in celerite_engine.py.

Maybe some of these functionalities could be moved to the base class gp_engine.py? As they are all the same.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions