From 43fd05a1d0aad7a9c63d2d7d698e08d9ae04bc8a Mon Sep 17 00:00:00 2001 From: Night Date: Mon, 25 May 2026 11:24:59 +0800 Subject: [PATCH 1/2] Fix the memory leak in the sample app Replace the activity context to application context to prevent memory leak in Activity reconstruction case. --- .../java/com/google/credentialmanager/sample/JsonProvider.kt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt b/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt index 5452a633..f080c7fc 100644 --- a/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt +++ b/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt @@ -23,7 +23,10 @@ import android.content.Context * * @param context The application context. */ -class JsonProvider(private val context: Context) { +class JsonProvider(context: Context) { + + val context = context.applicationContext + /** * Fetches the registration JSON from the "RegFromServer" asset. * From e82493650d58ad97380f79863d65debc0695bc45 Mon Sep 17 00:00:00 2001 From: Night Date: Mon, 25 May 2026 11:32:00 +0800 Subject: [PATCH 2/2] Update the field visibility --- .../java/com/google/credentialmanager/sample/JsonProvider.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt b/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt index f080c7fc..d7931b4f 100644 --- a/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt +++ b/CredentialManager/app/src/main/java/com/google/credentialmanager/sample/JsonProvider.kt @@ -25,7 +25,7 @@ import android.content.Context */ class JsonProvider(context: Context) { - val context = context.applicationContext + private val context = context.applicationContext /** * Fetches the registration JSON from the "RegFromServer" asset.