Pattern OS Rectangular script#186
Merged
Merged
Conversation
pluAtAnsys
requested changes
Dec 8, 2025
| # ----------------------------------------------------------- | ||
| # UX for "Styling" + "Pillow Definition" | ||
| # ----------------------------------------------------------- | ||
| class RectangularParametersForm(Form): |
Collaborator
There was a problem hiding this comment.
please use numpy style for docstring
pluAtAnsys
reviewed
Dec 8, 2025
pluAtAnsys
reviewed
Dec 9, 2025
|
|
||
| # ------------- Pillow mode handling ------------- | ||
|
|
||
| def on_mode_changed(self, sender, event): |
Collaborator
There was a problem hiding this comment.
missing numpy style docstring
pluAtAnsys
reviewed
Dec 9, 2025
| """Update controls when Radii/Freeform selection changes.""" | ||
| self.update_pillow_controls() | ||
|
|
||
| def update_pillow_controls(self): |
Collaborator
There was a problem hiding this comment.
missing numpy style docstring
pluAtAnsys
requested changes
Dec 9, 2025
|
|
||
| # ------------- OK / Cancel ------------- | ||
|
|
||
| def on_ok(self, sender, event): |
Collaborator
There was a problem hiding this comment.
missing numpy style docstring
| self.DialogResult = DialogResult.OK | ||
| self.Close() | ||
|
|
||
| def on_cancel(self, sender, event): |
Collaborator
There was a problem hiding this comment.
missing numpy style docstring
Collaborator
Author
|
@pluAtAnsys I made some updates |
pluAtAnsys
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pluAtAnsys this is the tool i mentioned.
fyi @StefanThoene @gmoysan