Skip to content

MAINT: Update project proxy after save as#294

Open
rfahlberg wants to merge 8 commits into
mainfrom
maint/update_project_proxy_after_save_as
Open

MAINT: Update project proxy after save as#294
rfahlberg wants to merge 8 commits into
mainfrom
maint/update_project_proxy_after_save_as

Conversation

@rfahlberg

Copy link
Copy Markdown
Collaborator
  • Update project proxy after save as

@rfahlberg rfahlberg requested a review from widerschein May 22, 2024 06:41
@pyansys-automation

Copy link
Copy Markdown
Contributor

Hello @rfahlberg!
This issue has been open for over a year and has had no updates in the past 8 months. If it is still relevant, please provide an update. Otherwise, consider closing it to help keep the issue tracker clean.

If this issue needs to remain open, please comment below with @pyansys-automation never close issue to prevent it from being automatically closed.

If you want this repository to be excluded from this automated maintenance process, please let us know by filling in the opt-out request form.

@rfahlberg

Copy link
Copy Markdown
Collaborator Author

Hi @PanekOndrej, I did this change once because it seemed missing to me. However, everything seems to work fine also without this change. What do you think, should we add this or is it not necessary?

@PanekOndrej

Copy link
Copy Markdown
Collaborator

Hi @PanekOndrej, I did this change once because it seemed missing to me. However, everything seems to work fine also without this change. What do you think, should we add this or is it not necessary?

Hi @rfahlberg,

  • I think the bug fix of adding logger after open method is relevant. The project logger is not used anywhere in pyosl though, that's why everything seems to be working.
  • Regarding the second one, after using save_as, the project uid doesn't change, right? The uid property is basically the only information stored locally. Therefore, there should be no need to recreate the Project instance.

osl_server=self.__osl_server,
uid=self.__get_project_uid(),
logger=self._logger,
)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uid remains the same after using save_as method, there should be no need to update the project proxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants