deprecate: mark download_latent_parameters_json as deprecated#300
Merged
Conversation
msd-11
requested review from
awoimbee and
u8slvn
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Deprecates GeomAIWorkspace.download_latent_parameters_json and extends GeomAIWorkspace.get_latent_parameters to optionally write to / return a binary file object when a target file is provided.
Changes:
- Added a
PySimAIDepreciationWarningwarning todownload_latent_parameters_json. - Updated
get_latent_parametersto accept an optionalfileparameter and return either parsed JSON (no file) or a binary file/None(file provided). - Added a unit test covering the “file provided” behavior for
get_latent_parameters.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ansys/simai/core/data/geomai/workspaces.py |
Adds deprecation warning and modifies get_latent_parameters to optionally download into a file. |
tests/geomai/test_geomai_workspaces.py |
Adds a test to validate get_latent_parameters(file=...) returns binary content. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Marie Lelandais <125036775+marielelandais@users.noreply.github.com>
Co-authored-by: Marie Lelandais <125036775+marielelandais@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
awoimbee
approved these changes
Jun 2, 2026
marielelandais
approved these changes
Jun 4, 2026
marielelandais
left a comment
marielelandais
left a comment
Contributor
There was a problem hiding this comment.
Perfect! Thanks @msd-11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.