Module redefinition error when messages and packages share a name

[viluon]

Buffa v0.6.0 generates invalid code when there's both a message Oof (in package foo) with inner messages and a package foo.oof in the Proto sources. These end up mapping to two mod oofs. See the MRE at viluon/buffa-module-collision.

[iainmcgin]

Thanks for the clear MRE — reproduced it exactly. Root cause: protobuf is case-sensitive, so message Oof and package foo.oof legally coexist, but buffa emits a message's nested types in a snake_case module, so both mapped to mod oof.

Fix in #145: when a message's nested-types module collides with a sibling sub-package, the nested-types module is deconflicted with a trailing _. So you'd get foo::Oof (struct), foo::oof_::Inner (nested), and foo::oof::Thing (sub-package), all coexisting. The message struct and the sub-package keep their natural names; only the nested-types module moves, and only when there's an actual collision (so existing code that compiles is unaffected).

[viluon]

Thanks @iainmcgin, any plans/schedule for a new release? It's a blocker for some buffa users (requires patching the generated Rust to compile).