Widen approvals and denials counters to uint32_t#25
Open
Swissola wants to merge 3 commits into
Open
Conversation
sleep=Donald Duck, idle=Bongo Cat, busy=SpongeBob multitasking, attention=Surprised Pikachu (Nouns glasses), celebrate=Peanuts party, dizzy=Powerpuff Girls spiral eyes, heart=heart eyes ghost. Source GIFs in characters/memes-src/, device-ready pack in characters/memes/. Built with prep_character.py at 96x98px, 64 colours per frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Track the current peer BD address in onConnect (extended overload). bleRemoveCurrentBond() removes only that peer's LTK from NVS. The "unpair" JSON command now calls this instead of bleClearBonds(), so each host unpairs itself independently. bleClearBonds() is reserved for factory reset only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
uint16_t caps at 65535. A user approving ~30 tool calls a day hits the ceiling in under 6 years; overflow silently corrupts the mood calculation in statsMood() which uses the ratio to adjust the pet state tier. - Stats::approvals and Stats::denials: uint16_t -> uint32_t - NVS load/save: getUShort/putUShort -> getUInt/putUInt - Local copies in statsMood(): uint16_t -> uint32_t Existing NVS data migrates cleanly: getUInt reads a key previously written by putUShort and zero-extends the value correctly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stats::approvalsandStats::denials:uint16_ttouint32_tgetUShort/putUShorttogetUInt/putUIntstatsMood():uint16_ttouint32_tMotivation
uint16_tcaps at 65,535. A user who approves ~30 tool calls a day would hit the ceiling in under 6 years; at higher usage rates, much sooner. Overflow silently corrupts the mood calculation instatsMood()which uses the approval/denial ratio to adjust the pet's emotional state tier.Migration
Existing NVS data migrates cleanly —
getUInt()reading a key previously written byputUShort()zero-extends the value correctly on ESP32. No factory reset required.Test plan
🤖 Generated with Claude Code