Preserve transcript scroll position when new content arrives#26
Open
Swissola wants to merge 3 commits into
Open
Preserve transcript scroll position when new content arrives#26Swissola wants to merge 3 commits into
Swissola wants to merge 3 commits into
Conversation
sleep=Donald Duck, idle=Bongo Cat, busy=SpongeBob multitasking, attention=Surprised Pikachu (Nouns glasses), celebrate=Peanuts party, dizzy=Powerpuff Girls spiral eyes, heart=heart eyes ghost. Source GIFs in characters/memes-src/, device-ready pack in characters/memes/. Built with prep_character.py at 96x98px, 64 colours per frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Track the current peer BD address in onConnect (extended overload). bleRemoveCurrentBond() removes only that peer's LTK from NVS. The "unpair" JSON command now calls this instead of bleClearBonds(), so each host unpairs itself independently. bleClearBonds() is reserved for factory reset only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously any change to lineGen unconditionally reset msgScroll to 0, snapping the user back to the bottom. If you scrolled up to re-read earlier output while Claude was still generating, new content would immediately dump you back to the latest line. The maxBack clamp already handles the boundary case where msgScroll exceeds available rows after new content arrives, so removing the reset is the complete fix. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msgScroll = 0reset indrawTranscript()when new content arrivesTamaState::lineGenMotivation
Any change to
lineGenpreviously resetmsgScrollto 0, snapping the display back to the bottom of the transcript. If you scrolled up to re-read earlier output while Claude was still generating, new content would immediately dump you back to the latest line, making it impossible to read history during an active session.The existing
maxBackclamp (already present) handles the boundary case wheremsgScrollexceeds the number of available rows after new content is added, so removing the forced reset is the complete fix.Behaviour after this change
Test plan
🤖 Generated with Claude Code