stats: floor energy at 1 when on USB power#28
Open
Swissola wants to merge 3 commits into
Open
Conversation
sleep=Donald Duck, idle=Bongo Cat, busy=SpongeBob multitasking, attention=Surprised Pikachu (Nouns glasses), celebrate=Peanuts party, dizzy=Powerpuff Girls spiral eyes, heart=heart eyes ghost. Source GIFs in characters/memes-src/, device-ready pack in characters/memes/. Built with prep_character.py at 96x98px, 64 colours per frame. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Track the current peer BD address in onConnect (extended overload). bleRemoveCurrentBond() removes only that peer's LTK from NVS. The "unpair" JSON command now calls this instead of bleClearBonds(), so each host unpairs itself independently. bleClearBonds() is reserved for factory reset only. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The pet could show fully depleted (0/5 energy) even while plugged in, which looks wrong — a charging device should never appear dead. Pass _onUsb to statsEnergyTier() and use it to clamp the minimum to 1 when on USB power. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bool onUsb = falseparameter tostatsEnergyTier()_onUsbat the single call site inmain.cppMotivation
The pet could show fully depleted energy (0/5) even while plugged in. This looks wrong — a device sitting on a desk charging should never appear dead. When USB power is detected the energy display floors at 1 so it always shows at least a trace of life.
_onUsbis already tracked viaM5.Axp.GetVBusVoltage() > 4.0finclockRefreshRtc(); no new state is introduced.Behaviour after this change
Test plan
🤖 Generated with Claude Code